Remove power=sub_station/station rendering, add power=plant fill color #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two tags are deprecated and have been replaced by power=plant and power=substation
Previously substations and the old tag power=station had a fill color but power=plant did not
|
https://www.openstreetmap.org/#map=15/54.6608/20.5934 After https://www.openstreetmap.org/#map=16/54.6628646/20.5838245 After |
|
https://www.openstreetmap.org/#map=16/1.4501/103.8868.png After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3871
Fixes #3405
Changes proposed in this pull request:
@powerfill color forpower=plant, same as withpower=substationCurrently we still render the old tags power=sub_station and power=station, but the new tags power=substation and power=plant are many times more common now:
power=sub_station is much less popular than power=substation (300k > 13k)
power=station has dropped steadily (3k) vs power=plant (19k).
The newer tags
power=substationandpower=plantare already rendered, exceptpower=plantdoes not have an outline or fill color.An alternative would be to only render an outline, but I found this was confusing with
shop=mallareas in a previous PR. The fill color works better.