Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for man_made=petroleum_well #3494

Open
Adamant36 opened this issue Nov 3, 2018 · 29 comments
Open

Add icon for man_made=petroleum_well #3494

Adamant36 opened this issue Nov 3, 2018 · 29 comments
Labels
new features Requests to render new features POI
Milestone

Comments

@Adamant36
Copy link
Contributor

It would be cool if there was an icon for petroleum wells. There's a lot of them in northern California where I mainly map that haven't been added yet. Maybe it would get people to add them. Plus, they are important features of power and industrial infrastructure. Also, being rendered they would give important context to smaller industrial areas, where sometimes they are the only feature. The numbers are also there too. There's currently 52,090 of them mapped and the numbers seem to be increasing steadily.
petroleum well

@kocio-pl kocio-pl added the new features Requests to render new features label Nov 3, 2018
@kocio-pl kocio-pl added this to the New features milestone Nov 3, 2018
@matkoniecz
Copy link
Contributor

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 4, 2018 via email

@Tomasz-W
Copy link

Tomasz-W commented Nov 5, 2018

My icon proposal:

man_made petroleum_well

@Adamant36
Copy link
Contributor Author

@jeisenbe, I looked into it and there doesn't seem to be a way to tag them differently based on what type of well they are. There is a sub tag for if its an oil or gas well. Although I can't remember what it was now and its not listed on the tags wiki page for some reason. I don't think there would be an easy to tell what type of well it is by looking at satellite photos anyway. Plus, a lattice tower oil well icon might have the potential to be confused with other types of lattice towers. Whereas, its pretty to the meaning of @Tomasz-W's icon, but I also think its a well known enough image that people will know what it means for both types of wells.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 12, 2018 via email

@Adamant36
Copy link
Contributor Author

Alright. I'll probably test it and do a PR if everything goes as it should. Do you have an opinion on what zoom level it should start rendering at? Towers start rendering at z17. So that might work. starting at z18 might be better though.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 12, 2018 via email

@Tomasz-W
Copy link

@Adamant36
Copy link
Contributor Author

Adamant36 commented Nov 12, 2018

Bakersfield ended up being a good area.

z17
petroleum_well z17
z18
petroleum_well z18
z19
petroleum_well z19
I'm thinking z18 or even z19 maybe.

@Adamant36
Copy link
Contributor Author

Another area

z17
petroleum_well z17
z18
petroleum_well z18
z19
petroleum_well z19

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 12, 2018 via email

@Adamant36
Copy link
Contributor Author

Well that's cool. I agree with you. It does look better at z17 on the second one. About 5,000 of them are mapped with names and I was thinking the addition of names on them somewhere like in the first example might cause problems, but then I couldn't get OverpassTurbo to do a query for ones with names for some reason. So, I guess its not that much of issue. I doubt they would all have names where there is a bunch of them together anyway. Unless its miss-tagging.

@kocio-pl and @Tomasz-W what do you guys think?

@Adamant36
Copy link
Contributor Author

Adamant36 commented Nov 12, 2018

Hey @kocio-pl, I just noticed there is also man_made=pumping_rig. Do you think it would be worth adding? I'm not really sure what the difference between the two are, but at least its an approved tag with 2,393 uses.
taghistory 2

@SomeoneElseOSM
Copy link
Contributor

I doubt they would all have names where there is a bunch of them together anyway. Unless its
mis-tagging

For info, there are a bunch of named (and in some cases actually mistagged - some are no longer active) petroleum wells in the UK. See e.g. https://www.openstreetmap.org/#map=15/53.2563/-1.0090 and (in another rendering) https://map.atownsend.org.uk/maps/map/map.html#zoom=15&lat=53.25638&lon=-1.00952 . These came from a very old import in the UK.

@Tomasz-W
Copy link

@Adamant36 Petroleum wells are very rare in my country, there are none of them in my region, so I rather won't be a good adviser here.

@kocio-pl
Copy link
Collaborator

@Adamant36 I'm not sure and I'm not even interested in rendering oil-related objects. On the one hand they have its own tag, on the other hand it's listed as a tagging mistake, so probably it all needs discussion on Tagging list:

https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dpetroleum_well#Possible_Tagging_Mistakes

@jragusa
Copy link
Contributor

jragusa commented Nov 12, 2018

man_made=petroleum_well and man_made=pumping_rig are two different things. The well is only the tube inserted into the ground to reach the hydrocarbon reservoir (or water...). The pumping rig is just the machine used to "suck" the hydrocarbon from the well.
So you can have wells connected to a pumping platform and those alone and inactive because they are no more economically profitable.

Here, I suggest to use the present icon only to man_made=pumping_rig because man_made=petroleum_well are not really visible in the landscape since they are sealed at ground level. See for example here, here and here.

@kocio-pl
Copy link
Collaborator

This proposition makes sense for me. However tag scheme documentation is not clear and should be discussed so we know if this scheme is OK.

@Adamant36
Copy link
Contributor Author

@kocio-pl, they are listed as items that are possibly tagged wrong as each other. It doesn't sound like that means either tag shouldn't be used though. Doing a search for oil well in iD comes up with man_made=petroleum_well. So its at least accepted there and has way more numbers then the other one. It makes sense to render man_made=petroleum_well even if it and man_made=pumping_rig is different because a pumping rig depends on a petroleum well, whereas the other doesn't depend on a pumping rig. 99% of oil wells will get pumping rigs at some point. A lot of the petroleum wells are also tagged with abandoned. So I think ignoring the temporary state of them being just a whole in the ground versus not is the better to go and render them as the complete setup. Since that's most of them probably are. I don't think they take down the rig after the site runs out of oil either. So there's nothing misleading about it. I don't think many people are mapping sealed holes in the ground. Either way, man_made=petroleum_well is clearly the preferred tag of the two.

@kocio-pl
Copy link
Collaborator

It still needs some documentation cleaning before we start rendering, IMO. Since both are under man_made namespace, it's impossible to tag that pumping rig is mounted for petroleum (maybe it is for some other substance?), but it should be possible to not loose informations.

@Adamant36
Copy link
Contributor Author

Adamant36 commented Nov 13, 2018

That's why I think one of them should be rendered over the other. Although, I didn't find any places where they were tagged on the same thing. So it might not even be a problem. Maybe rigs should rendered with the current icon and wells should be rendered with a similar icon to water wells.

If anyone wants to ask on the mailing list feel free. Id like to see them rendered on the map, but I don't have that much spare time right now or id do it myself.

@kocio-pl
Copy link
Collaborator

Pumping rig can be used for different substances ("a tag for pumping platforms - gas, oil, etc." with substance=* - it should be also decided which tag is for describing what is being pumped), but we can start rendering it, since they all look the same probably.

For petroleum well we have no clarity if there is a rig or not, so tagging discussion is needed anyway, because we don't know how it relates to pumping rig tag. My intuition is that if we know there is a rig, it should be simply retagged as man_made=pumping_rig + substance=oil and all the rest should indicate lack of rig or that we don't know it.

@Adamant36
Copy link
Contributor Author

Alright. That sounds fair. I think pumping rig is the better tag anyway. Since it solves the issue of if there is a rig there or not. Especially since its approved and the other one isn't. I'll switch around the code and retest it.

@kocio-pl
Copy link
Collaborator

@boothym
Copy link
Contributor

boothym commented Jan 17, 2019

Just to point out regarding the numbers - over 7,000 uses are also tagged as disused=yes, from a UK import 10 years ago: https://overpass-turbo.eu/s/Fj8

@ArcticGnome
Copy link

Please do it. When I map in Alberta, I often wonder why there are service roads going to nowhere, only to see that there is a tagged well when I get into editing mode.

@Adamant36
Copy link
Contributor Author

Personally, id like to. I have the same problem myself with many seamingly random roads going into farmland, there's currently an embargo on any new icons being added though. So its probably not going to happen until that gets worked out. Which I don't see happening anytime soon if ever. See the "to many icons" issue.

@jragusa
Copy link
Contributor

jragusa commented Apr 2, 2019

You will get basically a lot of disused wells in some areas. It's especially the case with shale gas (take a look in Pennsylvania for example). But as I said some months ago, it's much more interesting to render pumping_rig than wells which are underground features.

@boothym most of wells in your request are located on the sea floor of the North sea which raises an other problem: their rendering should be restricted to terrestrial area unless you dive at several hundred meters depth ;)

@ealgase
Copy link

ealgase commented Sep 6, 2022

Can we have some progress on this? Going to note that man_made=pumping_rig has been deprecated so man_made=petroleum_well should be rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new features Requests to render new features POI
Projects
None yet
Development

No branches or pull requests

10 participants