Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render man_made=water_well #1224

Open
zdila opened this issue Jan 14, 2015 · 58 comments
Open

Render man_made=water_well #1224

zdila opened this issue Jan 14, 2015 · 58 comments

Comments

@zdila
Copy link

zdila commented Jan 14, 2015

Many famous mineral water sources are tagged as man_made=water_well so they should be rendered on OSM.

@matkoniecz
Copy link
Contributor

Can you give examples?

@matkoniecz
Copy link
Contributor

Sorry for being imprecise - can you give examples of OSM elements (node/way/relation)?

@zdila
Copy link
Author

zdila commented Jan 14, 2015

@maraf24
Copy link

maraf24 commented Jan 18, 2015

Add amenity=drinking_water to them.

@zdila
Copy link
Author

zdila commented Jan 19, 2015

maraf24, I think this would be mapping for renderer. Maybe man_made=water_well could imply amenity=drinking_water unless it has drinking_water=no. Same for springs.

I would also like to have different icons for mineral water sources, but for that there is no standardised tagging yet.

@maraf24
Copy link

maraf24 commented Jan 19, 2015

I was merely stating the fact that your water wells lack tag for drinkable water. It could be drinking_water=yes or amenity=drinking_water. The latter has an advantage of being rendered.

However the main point is that man_made=water_well is not rendered at all. Certainly, if it has drinking_water=yes it should be rendered at the same zoom level as amenity=drinking_water, maybe even with the same icon.
The same goes for recently approved man_made=water_tap.

@zdila
Copy link
Author

zdila commented Jan 19, 2015

Now what about springs and water_wells with dirty - non drinkable water? Should they be rendered?

Hypotetically somebody coult even tag water source as amenity=drinking_water together with drinking_water=no. It could be some amenity really built to provide drinking water which has become (maybe temporailry) contaminated.

@matkoniecz
Copy link
Contributor

Certainly, if it has drinking_water=yes it should be rendered at the same zoom level as amenity=drinking_water, maybe even with the same icon.

If it fits definition of amenity=drinking_water - it should be tagged also as amenity=drinking_water (it sounds like a good validator rule for JOSM). Also, drinking_water is currently not available in database.

water_wells with dirty - non drinkable water? Should they be rendered?

IMHO rendering it at general purpose map is a poor idea. First problem is that it would be hard to express that it is water well with dirty water, not fully usable water well. Second problem - this feature is of really limited importance - even for me it is borderline.

@matthijsmelissen
Copy link
Collaborator

As far as I'm concerned, it could be rendered on the highest zoomlevels as part of the mapper feedback loop. From z19, or maybe from z18.

@matthijsmelissen matthijsmelissen added this to the New features milestone Feb 2, 2015
@dieterdreist
Copy link

2015-01-19 11:46 GMT+01:00 maraf24 [email protected]:

However the main point is that man_made=water_well is not rendered at all.
Certainly, if it has drinking_water=yes it should be rendered at the same
zoom level as amenity=drinking_water, maybe even with the same icon.

can also be interesting for historic wells, I have encountered quite a few
when mapping historic castles, mansions and the like. Sometimes they are
impressive structures, and they are nice to play for kids because of the
echo (they are usually secured by steel grates nowadays)

@Tomasz-W
Copy link

Tomasz-W commented Jan 5, 2018

Can we get back to this topic?

Now, there is over 81k of water wells. It's one of the most popular man_made=* values.
https://taginfo.openstreetmap.org/tags/?key=man_made&value=water_well

There is two options of potential icon shape:
-medieval well
https://i.pinimg.com/736x/a3/d7/db/a3d7dbb1eb1ca789debc8483ffaff993--water-well-zen-gardens.jpg
-modern pump
https://1.bp.blogspot.com/-wkrlDkQOq-U/UoJooKz_7VI/AAAAAAAAAVA/O8fDLx_PKok/s1600/SDC14667.JPG

What do you think? For me, a "pump" shape would be more universal and better.

@matkoniecz
Copy link
Contributor

Note that icon must work in just 14 X 14 pixels.

@SomeoneElseOSM
Copy link
Contributor

Here's what I went with in a different style: https://github.com/SomeoneElseOSM/openstreetmap-carto-AJT/blob/master/symbols/water_well.png . If you want to see the effect on a map find a well you're interested in in UK or Ireland and then have a look at it on https://map.atownsend.org.uk/maps/map/map.html .

@Tomasz-W
Copy link

Tomasz-W commented Jan 6, 2018

icon_well2

14x14: icon_well

What are your thoughts? Is it readable enough?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 7, 2018

I like this shape in general - it's very clear for me even with 14 px matrix. It lacks solid bottom, water output should be L-shaped and be probably attached a bit higher, but these are just details.

I think that pump symbol should be used only for man_made=water_well + pump=powered/manual(~11k). For other wells I'd like to show what you called a "medieval well". What do you think about it?

@Tomasz-W
Copy link

Tomasz-W commented Jan 7, 2018

Updated pump vector:

icon_well2

14x14: icon_well

Gist: https://gist.github.com/Tomasz-W/b55760c0b5db057e2b6046cc3935cb21

Medieval well icon project:

icon_well medieval 2

14x14: icon_well medieval

Gist: https://gist.github.com/Tomasz-W/04eefd0d1f2cc60cd19660c7450a5377

I'm not sure about making two icons. I'm worried that many of pumps are tagged without "pump=powered/manual" tag, and it doesn't mean these objects have a "medieval well" shape.

What about the colour? I would like to see a test rendering in two versions - man_made grey, and water blue (like fountains)

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 7, 2018

Great, that's really promising!

  • I think pump bottom should be bigger, the output longer and with a curve, plus it could be attached higher. On 14 px it's mostly fine, but this time I'd like to tweak the general look.

  • The well shape is good for me, I would only add a "rope" and I hesitate if the roof is really needed. I would also try if the wrench arm could be longer (this means probably shorter axis).

I guess that split is OK - if this is really the pump, one needs just to add the tag and plenty of images show me that traditional well is still popular.

I would use brown - man made is about things not usable for general public (just visible) and brown is for amenities, including drinking_water, which is very similar kind of object. I was trying different colors for fountains and I remember that marine blue was special, as other colors were simply too dark on water circle, so too much attention was given to the fountains, but that was not what I planned originally - it just came out during testing that blue works the best.

@Tomasz-W
Copy link

Tomasz-W commented Jan 7, 2018

@kocio-pl I've put both svg files on Gist. Can you do this final changes on your own hand? You are more experienced, so you know better which sizes of certain elements would work fine. For me, it would be a guesswork ;)

@kocio-pl
Copy link
Collaborator

We have also man_made=water_pump (760) - I bet there's not always well, it can also be attached to a city water pipes for example.

@kocio-pl
Copy link
Collaborator

Water well:
3) water_well-3
4) water_well-4

@kocio-pl
Copy link
Collaborator

Pump:
5) pump-5
6) pump-6

@Tomasz-W
Copy link

Tomasz-W commented Jan 23, 2018

Water well: honestly, both icons are good enought, we can treat "3)" as little bit more readable, because it has less elements
Pump: I can see there is thicker line on the right side in "6)", but also, both icons are good enought, and I would choose "5)"

@dieterdreist
Copy link

dieterdreist commented Jan 23, 2018 via email

@kocio-pl
Copy link
Collaborator

Water well icon is meant for general cases, pump icon is for https://wiki.openstreetmap.org/wiki/Key:pump (subcase of a water well).

@daganzdaanda
Copy link

Thanks for all the examples!
IMHO the abstract symbols work best. I do also like blue as a very intuitive water feature color. I'm not sure if there would be a conflict with transportation, tourism or office colours. The small size of the abstract symbols may be enough to avoid a real conflict.
Because of their size and complex shape, the more literal symbols are maybe too "loud".
Of course the abstract symbols have to be "learned" maybe a bit more than a "realistic" icon.

@Tomasz-W
Copy link

Tomasz-W commented Nov 9, 2018

Water-blue colour might be confusing as water well can be an abandoned or turned off just a free standing object.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 9, 2018 via email

@Tomasz-W
Copy link

Abstract shape is totally not understandable also for me.

@jeisenbe
Copy link
Collaborator

Perhaps @Tomasz-W can design a pump that is a compromise between pump-5 and the HDM manual pump?

HDM Manual Pump icon in Blue
Liberia z17
liberia-manual-hdm-z17-blue
Liberia z18
liberia-manual-hdm-blue-z18
Liberia z19
liberia-manualhdm-blue-z19
Berliner z17
berliner-hdm-z17-blue
Berliner z19
berliner-manual-hdm-blue-z19
Liberia 2
liberia2-hdm-blue-z18
Japan Temple z18
japantemple-z18-circle

HDM Manual Pump icon in Brown
Liberia z17
liberia-hdm-brown-z17
Liberia z19
liberia-hdm-brown-z19
Berliner z19
berliner-brown-hdm-z17
Liberia 2
liberia2-hdm-brown
Japan z19
japantemple-z19-pump-brown

HDM Manual Pump icon in Gray
Liberia z17
liberia-z17-hdm-gray
Liberia z19
liberia-hdm-gray-z19
Berliner
berliner-hdm-gray
Liberia 2
liberia2-hdm-gray
Japan Castle z18
japan-castle-hdm-gray-z18
Japan Temple z18
japan-temple-hdm-gray-z18

@jeisenbe
Copy link
Collaborator

Abstract spring icon with drinking water supplement
Adding the water glass icon for wells with drinking water
Lower left
Liberia z18
liberia-z18-abs-drinking
z19
liberia-19-abs-drink
Liberia2 z18
z18-abs-drinking

Above
liberia2-abs-drinking-top

Upper left
liberia2-drinking-upleft
liberia-abs-drinking-upleft

This is done with a supplemental icon, which can be moved around to different locations relative to the main icon, as desired:

      [zoom >= 18][drinking_water = 'yes'] {
        supplement/marker-file: url('symbols/drinking.svg');
        supplement/marker-fill: @water-icon;
        supplement/marker-transform: 'translate(-9,5)';
        supplement/marker-placement: interior;
        supplement/marker-clip: false;

@Adamant36
Copy link
Contributor

Adamant36 commented Nov 11, 2018

Hey, that's pretty snazzy. It might be a good solution to some other things also. Although, it might also give the false impression that there is another mapped poi next to the main one. Plus, it doesn't look like the position of the second rendered icon is consistent every time.

@Tomasz-W
Copy link

As I very like dot-rendering for some features on z17, because it's the simplest possible shape, I consider different icons for the same feature at different zoom level as bad idea:

  • as @Adamant36 said, "it might also give the false impression that there is another mapped poi next to the main one"
  • in might give some bug or rendering-in-progress impression
  • proposed smaller icon is not intuitive at all

@sfkeller
Copy link

sfkeller commented Apr 19, 2020

Do we have a common denominator to proceed?

I agree: showing same feature with different icons at different zoom level is a bad idea.

I just want to point to the fact, that the lack of a water well icon in Carto style obviously leads to "tagging for the renderer", where mappers just tag water wells as amenity=fountain or drinking_water. And as you know, there are currently >111 K objects tagged man_made=water_well in OSM. And it's mentioned in https://wiki.openstreetmap.org/wiki/Map_Features .

@jragusa
Copy link
Contributor

jragusa commented Apr 19, 2020

Owing to the large abundance of this tag, why not using three distinct icons with regard to the tag pump (https://wiki.openstreetmap.org/wiki/Key:pump) which is also frequently used (26 799) if we only consider recommended values:

  • pump=no: old fashion well
  • pump=yes: Pump HDM
  • pump=powered: Powered pump HDM

@jragusa
Copy link
Contributor

jragusa commented Sep 24, 2020

For the record, there is a proposal related to pump features : https://wiki.openstreetmap.org/wiki/Proposed_features/Pumping_proposal

This also applies to man_made=windpump (#4149) and man_made=petroleum_well (#3494)

@mfbehrens
Copy link

Is anybody still working on this topic?

@imagico
Copy link
Collaborator

imagico commented Aug 9, 2021

Speaking for myself only - i have on my todo list the idea to further explore the concept of compound symbols (for amenity=drinking_water/drinking_water=yes in combination with man_made=water_well/man_made=water_tap/natural=spring but also for things like amenity=watering_place - see #3703 (comment), #4441 (comment))

Someone working on a suitable implementation of rendering man_made=water_well would definitely be helpful. But as you can see above there is no consensus among the maintainers how this should look like. I would not mind a solution different from my implementation but it would have to be non-misleading (in particular regarding confusion with man_made=water_tap - see #3011) and culturally generic so it is suitable for all kinds of wells in different settings.

The solution i showed (http://blog.imagico.de/the-way-of-the-water/) has in particular the advantages of

@sfkeller
Copy link

sfkeller commented Oct 3, 2021

This is just for your information in support of this proposal - especially imagico's - in addition to my arguments here #1224 (comment) .

Currently there's a proposed tag man_made=borehole [1] and the Project of the month Switzerland of October 2021 [2] will be "Fountains" including amenity=fountain and others like amenity=drinking_water / water_point and man_made=water_well / water_tap.

I know well the burden of volunteered maintenance. But the fact that only amenity=fountain and amenity=drinking_water (from the above list) are rendered in OSM carto style - although proposed since 6 years - means, that we need additional energy now, motivating mappers and preventing newcomers not to map for the renderer.

[1] https://wiki.openstreetmap.org/wiki/Proposed_features/Bore
[2] https://wiki.openstreetmap.org/wiki/PotM_CH

@imagico
Copy link
Collaborator

imagico commented Oct 6, 2021

I completely concur that rendering natural=spring and amenity=fountain but not man_made=water_well creates negative mapping incentives.

To make this clear for everyone who might be interested in working on this: For adopting the design approach for springs, wells and fountains (+ potentially geysers) i showed in http://blog.imagico.de/the-way-of-the-water/ there is essentially only one prerequisite:

Making bright and strong blue color for symbols exclusive to water features. Currently there are four different bright and strong blue colors used in this style and three are used for water related features - transportation, spring, waterfall and fountain all have different colors. Transportation would need to be moved to something non-blue (the airport/ferry terminal violet is an obvious choice), spring and fountain would be unified into a new water symbols color. The dark blue used for offices is sufficiently far away from that to not cause problems.

I know that this would still be a huge change for the overall appearance of the map - the blue transportation/accommodation symbols have been a trademark design element of this style since the beginning. But i am pretty sure that not overloading the full spectrum of colors for point symbols but limiting this more and aligning the choice of symbol colors to the choices of fill colors for polygons and line colors to some extent (i.e. blue for water related features, green for vegetation related features) is very helpful for map readability and clarity. We have taken this step a long time ago for roads already - moving from the colors-of-the-rainbow scheme with blue motorways, green trunk and red primary to the current red-orange-yellow-white gradient which most consider now a very good move for map usability and maintainability.

The optimal choice of water symbol color will depend a bit on the water color scheme, i.e. #4128. But that is just fine tuning.

@matkoniecz
Copy link
Contributor

Transportation would need to be moved to something non-blue (the airport/ferry terminal violet is an obvious choice), spring and fountain would be unified into a new water symbols color.

Seems like a good idea to me, and I see no big problem with

the blue transportation/accommodation symbols have been a trademark design element of this style since the beginning.

@BertMule
Copy link

BertMule commented Jun 9, 2023

My use is both in medieval setting as a true well (like Burcht), and as a pump in historic setting like on squares or community gardens (Sint Annahofje.)
I can imagine to distinguish with separate icons.

This topic is around since 2015!
It's disappointing that though we agree there should be something, and many proposale have been made, this topic is already left behind for a 8 years.
I'd rather see a tag removed/replaced, than that it is effectively useless.

There are a lot more of them.
I would say that every accepted tag (no too many please) should also be rendered (at least on some map).

@sfkeller
Copy link

sfkeller commented Jun 9, 2023

It's disappointing that though we agree there should be something, and many proposale have been made, this topic is already left behind for a 8 years.

Agreed. But now we are so close. And hope springs eternal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests