Identity-based auth #1067
Merged
Identity-based auth #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does not change tctl behavior
First part of addressing #1033 is ability to load credentials from the credentials file(s). This commit adds -i flag processing, i.e. a certificate can be fed via a cert.file and used to login.
Hooked up -i auth into the proper place
key-agent changes: tsh now ignores public keys loaded from the SSH key agent unless they are certificates. this fixes the problem of 'host auth' callback being called for 3rd party public keys in the SSH-agent (and tsh had no choice but to prompt user if he wanted to add thoses hosts to known_hosts file) tctl auth changes: `tctl auth` now outputs to stdout by default. If you set -o to a file, it will use that file instead. Getting rid of -o was not possible because it's still useful if --format is set to `dir` (OpenSSH compatible output). other changes: - added more detailed comments in a few places - restored error handling logic
russjones
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaner version of #1063