Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI should not display sessions when sessions recording has been disabled #1429

Closed
russjones opened this issue Oct 25, 2017 · 4 comments · Fixed by #1521
Closed

Web UI should not display sessions when sessions recording has been disabled #1429

russjones opened this issue Oct 25, 2017 · 4 comments · Fixed by #1521
Assignees
Labels

Comments

@russjones
Copy link
Contributor

russjones commented Oct 25, 2017

Problem

The Web UI uses this audit log to construct a list of sessions that can be played back. Once a user clicks play, then Web UI then fetches session related events (bytes and timing) and plays back the recorded session.

In Teleport 2.4, we will support disabling session recording, #1329 defines session_recording: off to disable recording of sessions. This disables session data, but leaves session related metadata in the audit log. When the user clicks on the sessions tab, the user sees all sessions with play next to them, but when clicked, nothing happens (because no session related events exist).

Proposed Solution

When the user clicks play, maybe we should have a popup that explains that the session was not recorded. I'll defer to @kontsevoy for the UX on this.

@russjones russjones added the ux label Oct 25, 2017
@russjones russjones added this to the 2.4.0 milestone Oct 25, 2017
@russjones russjones mentioned this issue Oct 25, 2017
14 tasks
@kontsevoy
Copy link
Contributor

Behavior

When a user clicks on "play" for a session which wasn't recorded the popup must be shown, saying:

The recording for this session is not available.

@alex-kovoy
Copy link
Contributor

alex-kovoy commented Dec 8, 2017

I suggest we hide these recordings and do not show them to the user. This way there is nothing to click on.

@kontsevoy
Copy link
Contributor

We must still show the list of old sessions. This information is valuable because it's basically a log of past logins.

@harsh3897
Copy link

Add Auditor role to user.

hatched pushed a commit that referenced this issue Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants