-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster level setting for enabling/disabling recording proxy #1329
Comments
ProposalImportant: read the comments. This proposal is obsolete.We have discussed this idea before, but punted. Now would be a good time to re-approach this. The idea was called "Cluster Configuration via tctl" Consider this YAML file: # cluster-config.yaml
kind: clusterConfig
version: v1
spec:
# session_recording possible options: "node" (default) "proxy" and "off"
session_recording: "node" This cannot be used with regular Instead, lets keep most of the resource file format (for example having a kind+version is very useful) but make a user-friendly CLI commands for applying config: # print the cluster configuration into stdout
$ tctl get config
# apply the new cluster config
$ tctl create cluster-config.yaml
# reset configuration to defaults:
$ tctl rm config Note: you don't have to specify "name" for the config resource because there's only one, and I propose to have just one configuration setting (proxy) for now and NOT migrate anything from teleport.yaml. Alternative Approach
|
I like the ability to easily change cluster level configuration. Right now to make cluster level changes you have the following options:
In addition, it would be nice to consolidate all cluster level configuration (name, static tokens, and auth preferences) so we can easily add to it and operate on it. |
Updated ProposalWe have decided that moving to a dynamic cluster config is better be done all-at-once, and it should include the ability to change things like static tokens and a cluster name. For now, it's much better from user expectation's point of view to simply add a new setting to # fragment of /etc/teleport.yaml
auth_service:
# session_recording possible options: "node" (default) "proxy" and "off"
session_recording: "node" |
* Also fix bug for accessing undefined fields when requesting createConnectionDiagnostic * Enable and fix useless fragment eslint error (#1327) * Also adds react-hooks eslint warnings * Update e-ref
We should be able to enable and disable #1327 at the cluster level.
The proxy will use it for two purposes. The first is determine when it gets a request will it be running in the normal mode or will it be recording and forwarding traffic. The second is if it is running in recording and forwarding mode, it will need to request a role with
RW
access toservices.CertAuthority
resources.Teleport nodes also need access to this setting so they can stop shipping audit logs to the Auth Server to prevent double logging.
The default setting for this should be normal mode.
The text was updated successfully, but these errors were encountered: