Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dependency to graphql-core-next #988

Merged
merged 27 commits into from
Aug 12, 2019
Merged

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Jun 2, 2019

No description provided.

@ekampf ekampf added work in progress 3.0 Fix/Release version 3.0 labels Jun 2, 2019
@ekampf ekampf changed the base branch from master to next/master June 2, 2019 05:08
@mvanlonden mvanlonden changed the title [WIP] Change dependency to graphql-core-next Change dependency to graphql-core-next Aug 9, 2019
@mvanlonden mvanlonden requested review from Cito and jkimbo August 9, 2019 16:06
@mvanlonden mvanlonden force-pushed the next/feature/core-next branch 2 times, most recently from d9c9b90 to 0d15823 Compare August 9, 2019 16:17
@mvanlonden mvanlonden force-pushed the next/feature/core-next branch from 0d15823 to 55c7a67 Compare August 9, 2019 16:18
mvanlonden
mvanlonden previously approved these changes Aug 9, 2019
jkimbo
jkimbo previously approved these changes Aug 9, 2019
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment suggestion. Otherwise looks great!

@mvanlonden mvanlonden dismissed stale reviews from jkimbo and themself via 4b0cac5 August 10, 2019 15:07
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the conflicts, things should be fine now.

@mvanlonden mvanlonden merged commit 7ef3c8e into next/master Aug 12, 2019
@mvanlonden mvanlonden deleted the next/feature/core-next branch August 12, 2019 18:04
mvanlonden added a commit that referenced this pull request Aug 17, 2019
* v3.0 - remove Python 2.x from build (#983)

* Change travis to only compile for p3.6+

* Changed tox to only run Python 3.6+

* Changed library classifiers to reflect support in Python 3.6+

* Changed version to 3.0.0 development

In [15]: get_version((3, 0, 0, "alpha", 0))
Out[15]: '3.0.dev20190601212304'

* Reorganize Tests (#985)

We no longer need a dedicated folder for Python3.6+ tests
We no longer need to check six.PY3 in tests

* Upgrade black to 19.3b0 (#987)

* Remove six dependency (#986)

* No one is using func_name

* Remove six simple usages

* Remove six requirement

* Remove `six.with_metaclass` calls

* pytest-asyncio should be a regular dependency now with Py3 move

* Change dependency to graphql-core-next (#988)

* Changed dependencies to core-next

* Converted Scalars

* ResolveInfo name change

* Ignore .venv

* Make Schema compatible with GraphQL-core-next

* Ignore more venv names and mypy and pytest caches

* Remove print statements for debugging in schema test

* core-next now provides out_type and out_name

* Adapt date and time scalar types to core-next

* Ignore the non-standard result.invalid flag

* Results are named tuples in core-next (immutable)

* Enum values are returned as dict in core-next

* Fix mutation tests with promises

* Make all 345 tests pass with graphql-core-next

* Remove the compat module which was only needed for older Py version

* Remove object as base class (not needed in Py 3)

* We can assume that dicts are ordered in Py 3.6+

* Make use of the fact that dicts are iterable

* Use consistent style of importing from pytest

* Restore compatibility with graphql-relay-py v3

Add adpaters for the PageInfo and Connection args.

* Avoid various deprecation warnings

* Use graphql-core 3 instead of graphql-core-next

* Update dependencies, reformat changes with black

* Update graphene/relay/connection.py

Co-Authored-By: Jonathan Kim <[email protected]>

* Run black on setup.py

* Remove trailing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 Fix/Release version 3.0 work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants