Graphene v3 following v3 graphql-core #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change travis to only compile for p3.6+ * Changed tox to only run Python 3.6+ * Changed library classifiers to reflect support in Python 3.6+ * Changed version to 3.0.0 development In [15]: get_version((3, 0, 0, "alpha", 0)) Out[15]: '3.0.dev20190601212304'
We no longer need a dedicated folder for Python3.6+ tests We no longer need to check six.PY3 in tests
* No one is using func_name * Remove six simple usages * Remove six requirement * Remove `six.with_metaclass` calls
# Conflicts: # graphene/__init__.py
jkimbo
approved these changes
Aug 9, 2019
* Changed dependencies to core-next * Converted Scalars * ResolveInfo name change * Ignore .venv * Make Schema compatible with GraphQL-core-next * Ignore more venv names and mypy and pytest caches * Remove print statements for debugging in schema test * core-next now provides out_type and out_name * Adapt date and time scalar types to core-next * Ignore the non-standard result.invalid flag * Results are named tuples in core-next (immutable) * Enum values are returned as dict in core-next * Fix mutation tests with promises * Make all 345 tests pass with graphql-core-next * Remove the compat module which was only needed for older Py version * Remove object as base class (not needed in Py 3) * We can assume that dicts are ordered in Py 3.6+ * Make use of the fact that dicts are iterable * Use consistent style of importing from pytest * Restore compatibility with graphql-relay-py v3 Add adpaters for the PageInfo and Connection args. * Avoid various deprecation warnings * Use graphql-core 3 instead of graphql-core-next * Update dependencies, reformat changes with black * Update graphene/relay/connection.py Co-Authored-By: Jonathan Kim <[email protected]> * Run black on setup.py * Remove trailing whitespace
|
Blocked by #1054 |
ProjectCheshire
approved these changes
Aug 17, 2019
RJPercival
reviewed
Jul 4, 2023
| @@ -2,7 +2,7 @@ class _OldClass: | |||
| pass | |||
|
|
|||
|
|
|||
| class _NewClass(object): | |||
| class _NewClass: | |||
There was a problem hiding this comment.
This module can be simplified a bit now than Python 2 is not supported - this _OldClass and _NewClass stuff was purely to support Python 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphene compatibility with graphql-core v3
Order of operations:
Approve and merge 988 into next/master Change dependency to graphql-core-next #988Create a v2 branch from masterPR and merge next/master into master Graphene v3 following v3 graphql-core #1048Cut a v3.0.0a0 release from master