Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client nil checks to avoid panics #2008

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Add client nil checks to avoid panics #2008

merged 4 commits into from
Jan 29, 2025

Conversation

spinillos
Copy link
Member

Same as: #1999 but for the missing clients.

Probably we could do something nicer since it follows the same pattern everywhere. But at the moment we should stop the bleeding.

@spinillos spinillos requested review from a team as code owners January 29, 2025 09:48
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@spinillos spinillos self-assigned this Jan 29, 2025
Copy link
Contributor

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from ML

@spinillos spinillos merged commit f572d44 into main Jan 29, 2025
26 checks passed
@spinillos spinillos deleted the add-clients-nil-check branch January 29, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants