Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud: Check if cloud configuration exists #1999

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

spinillos
Copy link
Member

It adds a check if the GrafanaCloudAPI configuration is set to early fail and avoid to panic if its nil.

Also it adds checks to ensure that the datasource implements the necessary configuration. Information here.

@spinillos spinillos requested review from a team as code owners January 22, 2025 10:02
@spinillos spinillos self-assigned this Jan 22, 2025
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spinillos spinillos merged commit 1c9315d into main Jan 22, 2025
26 checks passed
@spinillos spinillos deleted the cloud/datasource-cloud-configuration-check branch January 22, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants