Move slack log report from message thread to button #4686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskhakov
added
release:enhancement
vstpme
reviewed
Jul 17, 2024
|
good point Vadim |
|
Here is the intermediate step to stop posting new messages #4750 |
joeyorlando
reviewed
Aug 19, 2024
Comment on lines
-159
to
-161
| "apps.slack.helpers.alert_group_representative.on_alert_group_action_triggered_async": {"queue": "slack"}, | ||
| "apps.slack.helpers.alert_group_representative.on_alert_group_update_log_report_async": {"queue": "slack"}, | ||
| "apps.slack.helpers.alert_group_representative.on_create_alert_slack_representative_async": {"queue": "slack"}, |
There was a problem hiding this comment.
removing these because apps.slack.helpers is not a valid directory and there's no logs over the past 30 days for apps.slack.helpers
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Will do a follow up PR shortly to actually drop these two tasks (once there’re none left in the queue) + drop the |
…/oncall into iskhakov/remove-slack-log-report
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
approved these changes
Aug 19, 2024
3 tasks
joeyorlando
added a commit
that referenced
this pull request
Aug 19, 2024
# What this PR does Follow up to #4686 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Continuation of Add slack button to show log report #4641
Which issue(s) this PR closes
Closes #3849
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.