Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack button to show log report #4641

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Conversation

iskhakov
Copy link
Contributor

@iskhakov iskhakov commented Jul 9, 2024

What this PR does

Add a button to show an alert group log report in Slack. After deployed we can remove it from the thread as requested in #3849

Screenshot 2024-07-09 at 11 29 48 PM Screenshot 2024-07-09 at 11 29 57 PM

Which issue(s) this PR closes

Closes [issue link here]

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@iskhakov iskhakov marked this pull request as ready for review July 9, 2024 15:28
@iskhakov iskhakov requested a review from a team July 9, 2024 15:28
@iskhakov iskhakov added pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes labels Jul 9, 2024
@iskhakov iskhakov changed the title Add button to show log report Add slack button to show log report Jul 9, 2024
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 would be curious to get @Konstantinov-Innokentii's eyes to see if it's compliant with the new chatops-proxy changes

@iskhakov iskhakov enabled auto-merge July 10, 2024 08:03
@iskhakov
Copy link
Contributor Author

iskhakov commented Jul 11, 2024

@Konstantinov-Innokentii's eyes to see if it's compliant with the new chatops-proxy changes

Should be alright as it doesn't have any interactivity

@iskhakov iskhakov added this pull request to the merge queue Jul 12, 2024
Merged via the queue into dev with commit deff52d Jul 12, 2024
21 checks passed
@iskhakov iskhakov deleted the iskhakov/log-report-button branch July 12, 2024 09:58
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2024
Stop posting a new message, as it is available from the button
(#4641)
This is an intermediate step, so we will only update posted messages but
not post new ones
Once the majority of messages are updated, we can remove this step
(#4686)
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
# What this PR does

Continuation of [Add slack button to show log report
#4641](#4641)

## Which issue(s) this PR closes

Closes #3849

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.

---------

Co-authored-by: Joey Orlando <[email protected]>
Co-authored-by: Joey Orlando <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants