MQE: Add support for resets function #9859
Conversation
lamida
force-pushed
the
lamida/mqe-resets-function
branch
2 times, most recently
from
2749328 to
30921cf
Compare
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Co-authored-by: Charles Korn <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
lamida
force-pushed
the
lamida/mqe-resets-function
branch
from
9c4f643 to
08264fe
Compare
|
|
||
| # Testing resets | ||
| load 1m | ||
| simple_metric_all_same_no_reset{num="0"} 0 0 0 0 0 0 0 0 |
There was a problem hiding this comment.
[nit] It might be clearer to change these series to use labels like these:
metric{case="all the same, no resets, value 0"}
metric{case="all the same, no resets, value 3"}
metric{case="all floats, no resets"}
metric{case="all floats, some resets"}
...
This would make the cases clearer given we can use full English phrases. Then the evals below can be collapsed into one eval range from 0 to X step Y resets(metric) as well.
There was a problem hiding this comment.
Refactored the test in 647feb3
| haveFloats := len(fHead) > 0 || len(fTail) > 0 | ||
| haveHistograms := len(hHead) > 0 || len(hTail) > 0 |
There was a problem hiding this comment.
[nit] The head slice will always be populated if there are any points, so we could drop the len(xTail) checks.
There was a problem hiding this comment.
Copied from xOverTime function 😆 . Such as. So this means, we can drop tail check there too, right? Maybe we can do it in another PR.
There was a problem hiding this comment.
Yep, we can drop it there too, and I'm happy for you to do that in another PR.
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.