MQE: Add support for deriv function #9858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
reviewed
Nov 10, 2024
There was a problem hiding this comment.
Could you please add tests that include:
- native histograms
- special cases like the range being all 0, the range all containing the same non-zero value, the range containing NaN, Inf, and -Inf
There was a problem hiding this comment.
Sure I will add today
There was a problem hiding this comment.
Added test in 185ea64
lamida
force-pushed
the
lamida/mqe-deriv-function
branch
3 times, most recently
from
185ea64 to
77641d8
Compare
charleskorn
approved these changes
Nov 12, 2024
| @@ -460,3 +460,38 @@ load 6m | |||
|
|
|||
| eval range from 0 to 96m step 6m round(series, scalar(toNearest)) | |||
| {a="b"} -5 2.7 0.5 20 10 3.25 0 1000.01 0 -1000000 NaN NaN NaN NaN _ _ 10 | |||
|
|
|||
| # Testing deriv | |||
There was a problem hiding this comment.
[nit] Similar comment to #9859 (comment) applies here as well
There was a problem hiding this comment.
Refactored the test in 6fdb1f6
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
lamida
force-pushed
the
lamida/mqe-deriv-function
branch
from
77641d8 to
7933bf1
Compare
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.