Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update loki-release workflows to build Docker images "natively" #15907

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Jan 23, 2025

What this PR does / why we need it:

Build Docker images "natively" on runner architecture

This PR changes the way how multi-arch images are built. Instead of cross-compiling on emulated architecture using multiple platforms in the docker buildx build command, it uses dedicated arm and amd runners to build images "natively" and later combining the resulting image digests into a multi-arch manifest.

Special notes for your reviewer:

This PR is equal to #15858 but the loki-release lib is vendored from upstream.
Upstream changes: grafana/loki-release#180

@chaudum chaudum requested a review from a team as a code owner January 23, 2025 07:05
This PR changes the way how multi-arch images are built. Instead of
cross-compiling on emulated architecture using multiple platforms in the
docker buildx build command, it uses dedicated arm and amd runners to
build images "natively" and later combining the resulting image digests
into a multi-arch manifest.

Signed-off-by: Christian Haudum <[email protected]>
@chaudum chaudum force-pushed the chaudum/update-loki-release-workflows branch from a96e020 to 8d9a0c3 Compare January 23, 2025 07:17
@chaudum chaudum changed the title chore(ci): Update loki-release workflows to build Docker images "natively" ci: Update loki-release workflows to build Docker images "natively" Jan 23, 2025
@chaudum chaudum merged commit 3b9d92b into main Jan 24, 2025
59 checks passed
@chaudum chaudum deleted the chaudum/update-loki-release-workflows branch January 24, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants