chore: Build docker images on runner arch #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the way how multi-arch images are built. Instead of cross-compiling on emulated architecture using multiple platforms in the docker buildx build command, it uses dedicated arm and amd runners to build images "natively" and later combining the resulting image digests into a multi-arch manifest. Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
native-docker-builds
branch
from
4d20fb6 to
7439558
Compare
…ners Signed-off-by: Christian Haudum <[email protected]>
paul1r
approved these changes
Jan 22, 2025
trevorwhitney
approved these changes
Jan 22, 2025
@trevorwhitney I found this article very insightful https://andrewlock.net/combining-multiple-docker-images-into-a-multi-arch-image/ |
chaudum
added a commit
to grafana/loki
that referenced
this pull request
Jan 24, 2025
…15907) **What this PR does / why we need it**: Build Docker images "natively" on runner architecture This PR changes the way how multi-arch images are built. Instead of cross-compiling on emulated architecture using multiple platforms in the docker buildx build command, it uses dedicated arm and amd runners to build images "natively" and later combining the resulting image digests into a multi-arch manifest. **Special notes for your reviewer**: Upstream changes: grafana/loki-release#180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the way how multi-arch images are built. Instead of cross-compiling on emulated architecture using multiple platforms in the docker buildx build command, it uses dedicated arm and amd runners to build images "natively" and later combining the resulting image digests into a multi-arch manifest.
Example of a successful workflow run: https://github.com/grafana/loki/actions/runs/12907676490