Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/exercise8 #28

Merged
merged 6 commits into from
Jun 12, 2018
Merged

Feature/exercise8 #28

merged 6 commits into from
Jun 12, 2018

Conversation

glabrat
Copy link
Collaborator

@glabrat glabrat commented Jun 11, 2018

No description provided.

@glabrat glabrat requested a review from gpincheiraa June 11, 2018 21:48
npm start & (wait-on http://localhost:3000 && cypress run --record --key $CYPRESS_RECORD_KEY)
npm start & (wait-on http://localhost:3000 && cypress run)

kill $(jobs -p) || true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me queda la duda si ya que quitaste el Dashboard esto sigue siendo necesario ...

Copy link
Collaborator Author

@glabrat glabrat Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sí, de hecho quité el dashboard, incluso el id en el cypress.json, que son las otras 3 build que están en rojo, solo la que tiene el comando kill es el que está en verde.

cypress-io/cypress-example-recipes#156

Al parecer es un tema entre travis beta y cypress, en el link parece que tienen un issue parecido al del proyecto.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excelente! lo mezclo!

@gpincheiraa gpincheiraa merged commit 118250e into master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants