Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis marks builds as failed but they passed #156

Closed
bahmutov opened this issue Jun 5, 2018 · 2 comments · Fixed by #157
Closed

Travis marks builds as failed but they passed #156

bahmutov opened this issue Jun 5, 2018 · 2 comments · Fixed by #157
Assignees
@bahmutov

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Jun 5, 2018

Some builds in internal PRs are marked as failed, but each command internally was successful. Example https://travis-ci.org/cypress-io/cypress-example-recipes/jobs/388102701

From discussion in travis-ci/travis-ci#8082 seems this might be related to

  • using secret variables
  • background processes (we use npm start &)
@bahmutov bahmutov self-assigned this Jun 5, 2018
bahmutov added a commit that referenced this issue Jun 5, 2018
@bahmutov
kill background jobs on travis for #156
aa0b61d
@bahmutov bahmutov mentioned this issue Jun 5, 2018
Merged
bahmutov added a commit that referenced this issue Jun 5, 2018
@bahmutov
Kill background travis jobs 156 (#157)
5f1b488 
* kill background jobs on travis for #156

* ignore kill command result
@jennifer-shehane
Copy link
Member

Could this be related to some of our users issues?

@bahmutov
Copy link
Contributor Author

bahmutov commented Jun 5, 2018

no, our test run exits successfully, it is Travis doing some dumb thing and not understanding what is going on at its end.

@glabrat glabrat mentioned this issue Jun 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahmutov bahmutov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Kill background travis jobs 156 cypress-io/cypress-example-recipes
2 participants
@jennifer-shehane @bahmutov