Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): set compileOnly dependencies #56

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix(deps): set compileOnly dependencies #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,18 @@ repositories {

dependencies {

api libs.groovy.core // Used in public api
compileOnly libs.grails.core // Used in public api, but provided
compileOnly libs.groovy.core // Used in public api, but provided
compileOnly libs.servlet.api // Provided

api libs.javamail.api // Used in public api
api libs.spring.context // Used in public api
api libs.spring.context.support // Used in public api

// These three libraries are used in public api, but not in a way
// These two libraries are used in public api, but not in a way
// that is meant to be consumed by users of the plugin.
// Therefore they are set to implementation to not expose unnecessarily
// to the compileClasspath of plugin users.
implementation libs.grails.core
implementation libs.grails.gsp
implementation libs.grails.web.common

Expand All @@ -40,6 +42,7 @@ dependencies {
implementation libs.springboot.autoconfigure

testImplementation libs.grails.testing.support.core
testImplementation libs.servlet.api
testImplementation libs.spock.core

integrationTestImplementation libs.groovy.xml
Expand Down
2 changes: 2 additions & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ greenmail = '2.0.1'
groovy = '4.0.23'
gsp = '7.0.0-SNAPSHOT'
javamail = '2.0.1'
servlet-api = '6.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be taken from the bom?

Copy link
Contributor

@codeconsole codeconsole Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like we have the servlet-api in the bom, but perhaps it should be there? Just because it is in the bom, doesn't me it will be resolved, but at least the correct version will be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the other versions, could be resolved from the bom? gsp, groovy, etc?

slf4j = '1.7.36'
spring = '6.1.13'
springboot = '3.3.4'
Expand All @@ -22,6 +23,7 @@ groovy-core = { module = 'org.apache.groovy:groovy', version.ref = 'groovy' }
grails-docs = { module = 'org.grails:grails-docs', version.ref = 'grails' }
groovy-templates = { module = 'org.apache.groovy:groovy-templates', version.ref = 'groovy' }
groovy-xml = { module = 'org.apache.groovy:groovy-xml', version.ref = 'groovy' }
servlet-api = { module = 'jakarta.servlet:jakarta.servlet-api', version.ref = 'servlet-api' }
javamail-api = { module = 'jakarta.mail:jakarta.mail-api', version.ref = 'javamail' }
javamail-impl = { module = 'com.sun.mail:jakarta.mail', version.ref = 'javamail' }
slf4j-nop = { module = 'org.slf4j:slf4j-nop', version.ref = 'slf4j' }
Expand Down
Loading