fix(deps): set compileOnly dependencies #56
Conversation
The `jakarta-servlet-api` was previously included as a transitive dependency, but it is no longer available through that path. To resolve the issue, this commit explicitly adds `jakarta-servlet-api` as a `compileOnly` dependency to ensure the necessary classes are available during compilation without bundling them into the final artifact. Also change scopes of `groovy` and `grails-core` dependencies to `compileOnly` as these will always be provided to a grails plugin.
|
@matrei yeah, unfortunately now the plugins have the burden of resolving the Due to AST transformations. Any plugin that has a TagLib or Controller will need the servlet-api added in order to be able to compile it. |
|
Quick question before you merge, should we be resolving the servlet-api and other versions from the bom instead? |
| @@ -5,6 +5,7 @@ greenmail = '2.0.1' | |||
| groovy = '4.0.23' | |||
| gsp = '7.0.0-SNAPSHOT' | |||
| javamail = '2.0.1' | |||
| servlet-api = '6.0.0' | |||
There was a problem hiding this comment.
should this be taken from the bom?
There was a problem hiding this comment.
It doesn't look like we have the servlet-api in the bom, but perhaps it should be there? Just because it is in the bom, doesn't me it will be resolved, but at least the correct version will be.
There was a problem hiding this comment.
Perhaps the other versions, could be resolved from the bom? gsp, groovy, etc?
Isn't that what the |
that's why I was asking. yeah, that looks like the best path.. The goal is to minimize dependency resolution and dependency imports. We have way too many dependency imports in our starter app that should not be needed. We really need to create a list of plugins that use AST transforms and identify what imports they need specific to those transforms. Those would probably be the only location for compileOnlyApi. |
|
Either way the servlet-api is going to be needed for And there are no ast transforms or traits in this class that will propagate the resolution of the servlet-api |
The
jakarta-servlet-apiwas previously included as a transitive dependency, but it is no longer available through that path. To resolve the issue, this commit explicitly addsjakarta-servlet-apias acompileOnlydependency to ensure the necessary classes are available during compilation without bundling them into the final artifact.Also change scopes of
groovyandgrails-coredependencies tocompileOnlyas these will always be provided to a grails plugin.