-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dotted circle filter #593
Merged
simoncozens
merged 25 commits into
googlefonts:main
from
simoncozens:dotted-circle-filter
Apr 25, 2022
Merged
Add dotted circle filter #593
simoncozens
merged 25 commits into
googlefonts:main
from
simoncozens:dotted-circle-filter
Apr 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madig
reviewed
Mar 1, 2022
madig
reviewed
Mar 1, 2022
madig
reviewed
Mar 1, 2022
madig
reviewed
Mar 1, 2022
madig
reviewed
Mar 1, 2022
Very nice idea, but could use some tests! 😀 Plus docstrings. |
anthrotype
reviewed
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a cool idea, thanks. Please consider adding a little test as well
I do plan to add some tests. |
madig
reviewed
Mar 2, 2022
madig
reviewed
Mar 2, 2022
madig
reviewed
Apr 20, 2022
anthrotype
reviewed
Apr 20, 2022
madig
reviewed
Apr 20, 2022
madig
reviewed
Apr 20, 2022
Good to go? |
anthrotype
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Fonts' fontbakery tool has recently made it mandatory for fonts supporting complex scripts to contain a dotted circle (U+25CC) glyph, and for this glyph to have appropriate anchors for all attachable marks.
This is a boring job to do manually, and both the drawing and the anchor positioning can be automated.
This PR introduces a filter which can be called at font build time (
--filter "ufo2ft.filters.dottedCircleFilter::DottedCircleFilter(pre=True)"
) which checks for the presence of a dotted circle glyph, adds one if there is not one present, computes average anchor positions for attaching anchors and adds any missing anchors to the dotted circle glyph.Example: