-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dotted circle #65
Dotted circle #65
Conversation
I haven't really encountered the dotted circle in Latin fonts so I'm wondering if it's overkill to include it in Latin Plus? |
But still, we are receiving the WARN. Otherwise, it could end up like one of the always ignored Warns
|
I wonder now if this filter to Add dotted circle should be included by default when using Builder. |
Thanks Viviana for bringing up the check, it's the origin of the problem imo. Maybe we should re-read that conversation that got opened and fixed in only 2 days: fonttools/fontbakery#3600 and see if we agree with it? I personally agree that it is good professional practice from the moment a font has combining marks, that is why I suggest it in Latin Plus —which is an optional/recommended glyph set. Pros for having it in Plus would be: Does it worth the trouble? If not I would only add it to the phonetic sets (where it is needed). If we think that it would actually be good to completely go along with that FB, and make it a convention to all designers; then let's make the builder generating it by default. I personally think the check should be skipped for all scripts expect the one where it is really needed. |
If it would be too complicated at least the second option would be ok.
Yes, the filter is already there
But even in those cases it is being skipped google/fonts#4850 (comment). And again, the filter seems to be already at hand to solve this. |
To reflect on mark attachment requirements in Docs
cc @vv-monsalve
Will update db and lists when confirmed.