fix(rust): Don't update dev-dependencies lacking a version key #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Benjamin E. Coe <[email protected]>
This is a non-breaking change. If you have a version key for a dev-dependency that has a path key, release-please will bump it as before. If you don't have a version key (which is recommended, and required for cargo-workspaces publish to work, see this discussion: https://github.com/pksunkara/cargo-workspaces/pull/53/files#r735178500 ) then release-please will no longer fail when trying to process your workspace. Closes googleapis#1094
google-cla
bot
added
the
cla: yes
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped) | [`^14.0.0` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/release-please).
fasterthanlime
changed the title
|
@fasterthanlime, @chingor13 was undertaking a major refactor to make release-please more flexible for some advanced features we need to build on top of it (we're moving towards adding better support for multiple release lines.).
|
|
Looks like I can't push the commit to resolve the conflicts here. We can change this PR to target the 12.6 branch as a backport and I can apply the diff to the v13 version in a separate PR |
bcoe
approved these changes
Dec 20, 2021
chingor13
pushed a commit
that referenced
this pull request
Dec 21, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [12.6.1](https://github.com/googleapis/release-please/compare/v12.6.0...v12.6.1) (2021-12-21) ### Bug Fixes * **rust:** Don't update dev-dependencies lacking a version key ([#1095](https://github.com/googleapis/release-please/issues/1095)) ([dc1bad9](https://github.com/googleapis/release-please/commit/dc1bad997ef0d028e280e75b0e6510a99d06cb44)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 22, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [13.0.0](https://github.com/googleapis/release-please/compare/v12.6.0...v13.0.0) (2021-12-22) ### ⚠ BREAKING CHANGES * releasers are now "strategies", more logic moved into base classes * Node 12 is now required * manifest is now main entrypoint for release please, and logic is shared between mono-repo/split-repo flow * versioning straregy now handled by VersionStrategies rather than regexes * merge Manifest and standard PR paths (#1104) ### Features * add `includeComponentInTag` option for strategies and hook up to `--monorepo-tags` ([#1119](https://github.com/googleapis/release-please/issues/1119)) ([bf9aacd](https://github.com/googleapis/release-please/commit/bf9aacdde3a97c453f6e3280035607c97c7dffcd)) * add ability to override merged commit message ([#1161](https://github.com/googleapis/release-please/issues/1161)) ([c568b57](https://github.com/googleapis/release-please/commit/c568b57280f2048f6dabbb716cdb4174c3386b91)), closes [#967](https://github.com/googleapis/release-please/issues/967) * add GitHub changelog notes generator ([#1120](https://github.com/googleapis/release-please/issues/1120)) ([1470661](https://github.com/googleapis/release-please/commit/1470661bd76a1e731585ed3fbf7363224c7a7a3e)) * enable specifying changelog section headings in the CLI ([#1162](https://github.com/googleapis/release-please/issues/1162)) ([aaa8342](https://github.com/googleapis/release-please/commit/aaa8342cd48062c56fe87b3296904274b7fb9dbe)), closes [#511](https://github.com/googleapis/release-please/issues/511) * **go:** add support for bumping a Go version file ([#1112](https://github.com/googleapis/release-please/issues/1112)) ([8f6e52b](https://github.com/googleapis/release-please/commit/8f6e52b27811e6838800c7152be74e13201eb9e1)) * reimplement custom pull request title ([#1122](https://github.com/googleapis/release-please/issues/1122)) ([2f3e84c](https://github.com/googleapis/release-please/commit/2f3e84c8c51f367cad8baae44c8d9f0727aa02a5)) * reimplement Java 1.0.0 special version bumping ([#1126](https://github.com/googleapis/release-please/issues/1126)) ([28bc76b](https://github.com/googleapis/release-please/commit/28bc76b35d9e1eff218a5be1b9b8cebb4b1e6f9d)) * return path along with created release ([#1114](https://github.com/googleapis/release-please/issues/1114)) ([81fc0f4](https://github.com/googleapis/release-please/commit/81fc0f49d75ec66ef1915be26330734abddd11d7)) ### Bug Fixes * add back version/major/minor/patch ([#1118](https://github.com/googleapis/release-please/issues/1118)) ([4b6ae50](https://github.com/googleapis/release-please/commit/4b6ae5049e39e6f5bca10b514256090ea76ef5bd)) * allow setting release-type at root of manifest config ([#1159](https://github.com/googleapis/release-please/issues/1159)) ([fc73b6d](https://github.com/googleapis/release-please/commit/fc73b6dd3f5f7ed449b9d304e53bada911e3190f)) * backfill commit files ([#1110](https://github.com/googleapis/release-please/issues/1110)) ([173ce70](https://github.com/googleapis/release-please/commit/173ce704c9413d7f0da820fdd2961166a5ff0b73)) * backfill latest release with version found in manifest ([#1131](https://github.com/googleapis/release-please/issues/1131)) ([94859a0](https://github.com/googleapis/release-please/commit/94859a0cfbc58724016daaefaca03f34a43e0473)) * **cli:** pass pull-request-title-pattern ([#1128](https://github.com/googleapis/release-please/issues/1128)) ([28d7727](https://github.com/googleapis/release-please/commit/28d7727bc827612b02a8fde58d13cd87f962a399)) * combined manifest PR should include labels ([#1137](https://github.com/googleapis/release-please/issues/1137)) ([d8bb7ca](https://github.com/googleapis/release-please/commit/d8bb7caddfa14aabd3bfa19008c10ed911638a66)) * fallback to look at releases when looking for latest release ([#1146](https://github.com/googleapis/release-please/issues/1146)) ([76ed1a7](https://github.com/googleapis/release-please/commit/76ed1a77e64f28b0af7d8125dce457b885f80e52)) * fallback to look at tags when looking for latest release ([#1160](https://github.com/googleapis/release-please/issues/1160)) ([e06c6ba](https://github.com/googleapis/release-please/commit/e06c6ba5c3ce29689275e495934d4a6785962d5b)) * GitHub#findFilesByExtension should treat prefix as a directory ([#1165](https://github.com/googleapis/release-please/issues/1165)) ([b48ec5b](https://github.com/googleapis/release-please/commit/b48ec5bc285233436d7cb1b367326a3c6dd555a9)) * **github:** correctly return maxResults releases ([#1134](https://github.com/googleapis/release-please/issues/1134)) ([25f6811](https://github.com/googleapis/release-please/commit/25f68113d0e0bfa5a181d616c11bfd5e573cfaf5)) * make PullRequest, ReleasePullRequest, Version fields readonly ([#1150](https://github.com/googleapis/release-please/issues/1150)) ([9659c1c](https://github.com/googleapis/release-please/commit/9659c1c868395394a40ff8f6caf9aaa7998fb8b8)) * Manifest.fromConfig can find latest release version without component ([#1123](https://github.com/googleapis/release-please/issues/1123)) ([0aeb67b](https://github.com/googleapis/release-please/commit/0aeb67b4c4a497b5570bdec10f5ab15e620b235d)) * merge manifest release PRs unless separatePullRequests is configured ([#1129](https://github.com/googleapis/release-please/issues/1129)) ([328009d](https://github.com/googleapis/release-please/commit/328009d10b4609441a6f8432fa0d2aa9df1f5ff0)) * only backfill files if requested ([#1151](https://github.com/googleapis/release-please/issues/1151)) ([ae007fe](https://github.com/googleapis/release-please/commit/ae007feb430e97f2995d6fd431f2825512651e3a)) * reimplement draft releases ([#1111](https://github.com/googleapis/release-please/issues/1111)) ([6f38b4a](https://github.com/googleapis/release-please/commit/6f38b4aa5a206b358468e623a020ef715257ddfe)) * **rust:** Don't update dev-dependencies lacking a version key ([#1095](https://github.com/googleapis/release-please/issues/1095)) ([#1152](https://github.com/googleapis/release-please/issues/1152)) ([56f37d9](https://github.com/googleapis/release-please/commit/56f37d997c75ec5bcc330b08b0e9e25c68329b7a)), closes [#1094](https://github.com/googleapis/release-please/issues/1094) * switch branch delimiter to `--` ([#1127](https://github.com/googleapis/release-please/issues/1127)) ([26442f1](https://github.com/googleapis/release-please/commit/26442f14356c387c9117f5d660b532185c8084c4)) ### Code Refactoring * manifest is now main entrypoint for release please, and logic is shared between mono-repo/split-repo flow ([fd8f9fc](https://github.com/googleapis/release-please/commit/fd8f9fc82838f3a3a05470dfe4dab4d3b47c6fa1)) * merge Manifest and standard PR paths ([#1104](https://github.com/googleapis/release-please/issues/1104)) ([fd8f9fc](https://github.com/googleapis/release-please/commit/fd8f9fc82838f3a3a05470dfe4dab4d3b47c6fa1)) * Node 12 is now required ([fd8f9fc](https://github.com/googleapis/release-please/commit/fd8f9fc82838f3a3a05470dfe4dab4d3b47c6fa1)) * releasers are now "strategies", more logic moved into base classes ([fd8f9fc](https://github.com/googleapis/release-please/commit/fd8f9fc82838f3a3a05470dfe4dab4d3b47c6fa1)) * versioning straregy now handled by VersionStrategies rather than regexes ([fd8f9fc](https://github.com/googleapis/release-please/commit/fd8f9fc82838f3a3a05470dfe4dab4d3b47c6fa1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-breaking change. If you have a version key for a
dev-dependency that has a path key, release-please will bump it
as before. If you don't have a version key (which is recommended,
and required for cargo-workspaces publish to work, see this discussion:
https://github.com/pksunkara/cargo-workspaces/pull/53/files#r735178500 )
then release-please will no longer fail when trying to process your
workspace.
Closes #1094
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1094 🦕