Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct the 404 github issue link in the log #1086

Merged
merged 2 commits into from
Oct 22, 2021
Merged

docs: correct the 404 github issue link in the log #1086

merged 2 commits into from
Oct 22, 2021

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Oct 15, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ocavue ocavue requested a review from a team October 15, 2021 07:01
@ocavue ocavue requested a review from a team as a code owner October 15, 2021 07:01
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2021
@ocavue ocavue changed the title fix: correct a typo in the log fix: correct the 404 github issue link in the log Oct 15, 2021
@bcoe bcoe changed the title fix: correct the 404 github issue link in the log docs: correct the 404 github issue link in the log Oct 22, 2021
@bcoe bcoe merged commit 9c5096b into googleapis:main Oct 22, 2021
@bcoe
Copy link
Contributor

bcoe commented Oct 22, 2021

@ocavue thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocavue @bcoe