Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate pandas code paths that don't use pyarrow #48

Merged
merged 6 commits into from
Mar 17, 2020
Merged

chore: deprecate pandas code paths that don't use pyarrow #48

merged 6 commits into from
Mar 17, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Feb 26, 2020

Fixes #3.

This PR adds warnings when a pandas code path is taken without the pyarrow dependency available.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Feb 26, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2020
@plamut plamut requested a review from tswast February 26, 2020 15:36
@tswast tswast requested a review from shollyman February 26, 2020 16:31
@plamut
Copy link
Contributor Author

plamut commented Feb 26, 2020

I'll check tomorrow why Python 3.8 unit tests fail on Kokoro, we might need to merge #47 first, or maybe Kokoro does not yet have full support for Python 3.8?
(the tests pass locally just fine)

@plamut
Copy link
Contributor Author

plamut commented Feb 27, 2020

Figured it out, it's indeed #47 that has to be merged first, because currently pyarrow is not installed when running unit tests with Python 3.8, resulting in different code paths taken.

@plamut plamut added the status: blocked Resolving the issue is dependent on other work. label Feb 27, 2020
@plamut plamut removed the status: blocked Resolving the issue is dependent on other work. label Mar 4, 2020
shollyman
shollyman approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@plamut plamut merged commit be5c8b1 into googleapis:master Mar 17, 2020
@plamut plamut deleted the iss-3 branch March 17, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: deprecate pandas code paths that do not use pyarrow
3 participants
@plamut @shollyman @googlebot