Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: declare full Python 3.8 support #47

Merged
merged 4 commits into from
Mar 4, 2020
Merged

chore: declare full Python 3.8 support #47

merged 4 commits into from
Mar 4, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Feb 26, 2020

Fixes #12.

This PR declares full support for Python 3.8 and uses/includes the latter to run various nox sessions.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Feb 26, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2020
@plamut plamut requested a review from tswast February 26, 2020 11:43
This was referenced Feb 26, 2020
Merged
Closed
@tswast tswast requested a review from shollyman March 3, 2020 17:14
@plamut
Copy link
Contributor Author

plamut commented Mar 4, 2020

Seems like a system test flakiness, BackoffFailed - re-running.

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2020
@plamut plamut merged commit c88a6dd into googleapis:master Mar 4, 2020
@plamut plamut deleted the iss-12 branch March 4, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: test with all optional dependencies in Python 3.8
5 participants
@plamut @tswast @shollyman @googlebot @yoshi-kokoro