Skip to content
This repository was archived by the owner on Sep 9, 2023. It is now read-only.

samples: updates samples to v1 (3 of 8) #215

Merged
merged 13 commits into from
Apr 21, 2021
Merged

samples: updates samples to v1 (3 of 8) #215

merged 13 commits into from
Apr 21, 2021

Conversation

telpirion
Copy link
Contributor

This updates the java-aiplatform samples to use the v1 version of the samples.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 31, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2021
@telpirion telpirion changed the title samples: updates samples to v1 (3 of 10) [WIP] samples: updates samples to v1 (3 of 10) Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #215 (202db77) into master (609f5d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #215   +/-   ##
=========================================
  Coverage     78.06%   78.06%           
  Complexity     1402     1402           
=========================================
  Files            97       97           
  Lines         10158    10158           
  Branches        137      137           
=========================================
  Hits           7930     7930           
  Misses         2051     2051           
  Partials        177      177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609f5d2...202db77. Read the comment docs.

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Apr 13, 2021
@telpirion telpirion changed the title [WIP] samples: updates samples to v1 (3 of 10) samples: updates samples to v1 (3 of 10) Apr 14, 2021
@telpirion telpirion marked this pull request as ready for review April 14, 2021 19:09
@telpirion telpirion requested a review from a team April 14, 2021 19:09
@telpirion telpirion changed the title samples: updates samples to v1 (3 of 10) samples: updates samples to v1 (3 of 9) Apr 15, 2021
@telpirion telpirion changed the title samples: updates samples to v1 (3 of 9) samples: updates samples to v1 (3 of 8) Apr 15, 2021
@snippet-bot
Copy link

snippet-bot bot commented Apr 15, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2021
averikitsch
averikitsch reviewed Apr 16, 2021
View reviewed changes
samples/snippets/src/main/java/aiplatform/CreateTrainingPipelineCustomJobSample.java
@@ -1,5 +1,5 @@
/*
* Copyright 2020 Google LLC
* Copyright 2021 Google LLC
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no need to update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for letting me know!

averikitsch
averikitsch reviewed Apr 16, 2021
View reviewed changes
samples/snippets/src/main/java/aiplatform/CreateTrainingPipelineImageClassificationSample.java
System.out.format(
"Feature Attributions Schema_uri: %s\n",
explanationMetadata.getFeatureAttributionsSchemaUri());

Status status = trainingPipelineResponse.getError();
System.out.println("Error");
Copy link

@averikitsch averikitsch Apr 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this suppose to error or does this need a catch statement? (same for other samples)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the service might run into an error during model training that is unrelated to the request sent by the customer. There isn't an error that we can catch for this. (Same as other samples.)

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2021
@telpirion telpirion requested a review from averikitsch April 19, 2021 20:01
@telpirion telpirion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2021
@telpirion telpirion merged commit 67e67db into master Apr 21, 2021
@telpirion telpirion deleted the v1-samples-3 branch April 21, 2021 16:06
@telpirion
Copy link
Contributor Author

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@averikitsch averikitsch averikitsch approved these changes

Assignees

@averikitsch averikitsch

Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@telpirion @averikitsch @yoshi-kokoro