samples: adds custom model, action recognition samples and tests #111

telpirion · 2020-12-11T18:59:42Z

Adds new code snippets.

generated-files-bot · 2020-12-11T18:59:45Z

Warning: This pull request is touching the following templated files:

samples/snippets/pom.xml

snippet-bot · 2020-12-11T18:59:52Z

Here is the summary of changes.

You added 15 region tags.

samples/snippets/src/main/java/aiplatform/CreateBatchPredictionJobBigquerySample.java:19, tag aiplatform_create_batch_prediction_job_bigquery_sample
samples/snippets/src/main/java/aiplatform/CreateBatchPredictionJobSample.java:19, tag aiplatform_create_batch_prediction_job_sample
samples/snippets/src/main/java/aiplatform/CreateBatchPredictionJobVideoActionRecognitionSample.java:19, tag aiplatform_create_batch_prediction_job_video_action_recognition_sample
samples/snippets/src/main/java/aiplatform/CreateDataLabelingJobActiveLearningSample.java:19, tag aiplatform_create_data_labeling_job_active_learning_sample
samples/snippets/src/main/java/aiplatform/CreateDataLabelingJobSpecialistPoolSample.java:19, tag aiplatform_create_data_labeling_job_specialist_pool_sample
samples/snippets/src/main/java/aiplatform/CreateHyperparameterTuningJobPythonPackageSample.java:19, tag aiplatform_create_hyperparameter_tuning_job_python_package_sample
samples/snippets/src/main/java/aiplatform/CreateHyperparameterTuningJobSample.java:19, tag aiplatform_create_hyperparameter_tuning_job_sample
samples/snippets/src/main/java/aiplatform/CreateTrainingPipelineCustomJobSample.java:19, tag aiplatform_create_training_pipeline_custom_job_sample
samples/snippets/src/main/java/aiplatform/CreateTrainingPipelineCustomTrainingManagedDatasetSample.java:19, tag aiplatform_create_training_pipeline_custom_training_managed_dataset_sample
samples/snippets/src/main/java/aiplatform/CreateTrainingPipelineVideoActionRecognitionSample.java:19, tag aiplatform_create_training_pipeline_video_action_recognition_sample
samples/snippets/src/main/java/aiplatform/DeployModelCustomTrainedModelSample.java:19, tag aiplatform_deploy_model_custom_trained_model_sample
samples/snippets/src/main/java/aiplatform/ExportModelVideoActionRecognitionSample.java:19, tag aiplatform_export_model_video_action_recognition_sample
samples/snippets/src/main/java/aiplatform/GetHyperparameterTuningJobSample.java:19, tag aiplatform_get_hyperparameter_tuning_job_sample
samples/snippets/src/main/java/aiplatform/GetModelEvaluationVideoActionRecognitionSample.java:19, tag aiplatform_get_model_evaluation_video_action_recognition_sample
samples/snippets/src/main/java/aiplatform/ImportDataVideoActionRecognitionSample.java:19, tag aiplatform_import_data_video_action_recognition_sample

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

lesv · 2020-12-11T19:33:49Z

samples/snippets/nbactions.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>


Copyright & license on human created files

Ew, I didn't mean to include that. Sorry! I'll remove that from this PR.

lesv

Consider comments

lesv · 2020-12-11T19:36:51Z

samples/snippets/src/main/java/aiplatform/CreateHyperparameterTuningJobPythonPackageSample.java

+//import com.google.cloud.aiplatform.v1beta1.ClassOfConditionalParameterDecay;
+//import com.google.cloud.aiplatform.v1beta1.ClassOfConditionalParameterLearningRate;
+//import com.google.cloud.aiplatform.v1beta1.ClassOfDiscreteValueSpec;
+//import com.google.cloud.aiplatform.v1beta1.ClassOfDoubleValueSpec;
+//import com.google.cloud.aiplatform.v1beta1.ClassOfMetric;
+//import com.google.cloud.aiplatform.v1beta1.ClassOfParameter;
+//import com.google.cloud.aiplatform.v1beta1.ClassOfParameterSpec;
+//import com.google.cloud.aiplatform.v1beta1.ClassOfParentDiscreteValues;


We don't usually leave these in.

lesv · 2020-12-11T19:39:09Z

samples/snippets/src/main/java/aiplatform/CreateTrainingPipelineCustomJobSample.java

+    PipelineServiceSettings settings =
+        PipelineServiceSettings.newBuilder()
+            .setEndpoint("us-central1-aiplatform.googleapis.com:443")
+            .build();


Why are we doing this?

Acknowledged.

AI Platform doesn't have a global hostname, only locale-specific hostnames.

Consider adding a comment to this effect.

Acknowledged.

We've used this technique on every single sample in this repo. I'll create a GitHub issue to go back and add a comment in all of the places where we do this.

lesv · 2020-12-11T19:39:52Z

samples/snippets/src/main/java/aiplatform/CreateTrainingPipelineCustomJobSample.java

+              // A working docker image can be found at
+              // gs://cloud-samples-data/ai-platform/mnist_tfrecord/custom_job


If it's a docker image, why not use gcr.io or it's successor?

Acknowledged. @dizcology can give more context.

See Python canonical:
https://github.com/googleapis/python-aiplatform/blob/master/samples/snippets/create_training_pipeline_custom_job_sample.py#L41

In this case we are pointing the user to the Dockerfile and its content, since real use cases require the user to build and bring their own.

lesv · 2020-12-11T19:40:37Z

samples/snippets/src/main/java/aiplatform/CreateTrainingPipelineCustomJobSample.java

+      Value trainingTaskInputs = trainingTaskInputsBuilder.build();
+      String trainingTaskDefinition =
+          "gs://google-cloud-aiplatform/schema/trainingjob/definition/custom_task_1.0.0.yaml";
+      String imageUri = "gcr.io/cloud-aiplatform/prediction/tf-cpu.1-15:latest";


:latest is typically frowned upon.

Acknowledged. @dizcology can give more context.

See Python canonical:
https://github.com/googleapis/python-aiplatform/blob/master/samples/snippets/create_training_pipeline_custom_job_sample.py#L58

generated-files-bot · 2020-12-11T20:42:38Z

Warning: This pull request is touching the following templated files:

samples/snippets/pom.xml

generated-files-bot · 2020-12-11T20:50:53Z

Warning: This pull request is touching the following templated files:

samples/snippets/pom.xml

codecov · 2020-12-11T20:52:10Z

Codecov Report

Merging #111 (e562308) into master (e2d8e42) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #111   +/-   ##
=========================================
  Coverage     78.22%   78.22%           
  Complexity      704      704           
=========================================
  Files            48       48           
  Lines          5124     5124           
  Branches         69       69           
=========================================
  Hits           4008     4008           
  Misses         1027     1027           
  Partials         89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d8e42...e562308. Read the comment docs.

generated-files-bot · 2020-12-11T21:00:27Z

Warning: This pull request is touching the following templated files:

samples/snippets/pom.xml

generated-files-bot · 2020-12-11T22:20:35Z

Warning: This pull request is touching the following templated files:

samples/snippets/pom.xml

generated-files-bot · 2020-12-11T22:24:32Z

Warning: This pull request is touching the following templated files:

samples/snippets/pom.xml

generated-files-bot · 2020-12-11T22:35:14Z

Warning: This pull request is touching the following templated files:

samples/snippets/pom.xml

generated-files-bot · 2020-12-12T00:43:40Z

Warning: This pull request is touching the following templated files:

samples/snippets/pom.xml

telpirion · 2020-12-14T00:53:26Z

Thank you for the review, @lesv !

@chingor13 : It looks like this PR is still having issues with env vars. Your help is appreciated. Similarly, we accidentally deleted some of our test resources recently. I think that might be causing some of the 'Model is missing' errors in this PR.

chingor13 · 2020-12-14T20:01:42Z

samples/snippets/pom.xml

+        <groupId>org.glassfish</groupId>
+        <artifactId>javax.json</artifactId>
+        <version>1.1</version>
+      <type>jar</type>


Can we use either Jackson2 or GSON here?

chingor13 · 2020-12-14T20:03:36Z

samples/snippets/src/main/java/aiplatform/CreateBatchPredictionJobSample.java

+      JsonObject jsonModelParameters = Json.createObjectBuilder().build();
+      Value.Builder modelParametersBuilder = Value.newBuilder();
+      JsonFormat.parser().merge(jsonModelParameters.toString(), modelParametersBuilder);


This is pretty confusing - it looks like jsonModelParameters would be something empty?

Yeah, that is correct. You need to pass an empty Value object to the service for that field.

I'll add a note that clarifies this.

generated-files-bot · 2020-12-14T20:31:31Z

Warning: This pull request is touching the following templated files:

samples/snippets/pom.xml

chingor13

We should encourage usage of resource name helpers when available - they are more friendly than building the strings from scratch.

chingor13 · 2020-12-15T21:47:05Z

.../snippets/src/main/java/aiplatform/CreateBatchPredictionJobVideoActionRecognitionSample.java

+      BatchPredictionJob batchPredictionJob =
+          BatchPredictionJob.newBuilder()
+              .setDisplayName(displayName)
+              // Format: 'projects/{project}/locations/{location}/models/{model_id}'


For any resource name, we should probably demonstrate the resource name helpers:

String model = com.google.cloud.aiplatform.v1beta1.ModelName.of("project", "location", "model").toString();

chingor13 · 2020-12-15T21:48:52Z

samples/snippets/src/main/java/aiplatform/CreateDataLabelingJobActiveLearningSample.java

+      DataLabelingJob dataLabelingJob =
+          DataLabelingJob.newBuilder()
+              .setDisplayName(displayName)
+              // Full resource name: projects/{project}/locations/{location}/datasets/{dataset_id}


DatasetName.of("project", "location", "dataset");

chingor13 · 2020-12-15T21:49:53Z

samples/snippets/src/main/java/aiplatform/CreateDataLabelingJobSpecialistPoolSample.java

+                  "aiplatform.googleapis.com/annotation_set_name",
+                  "data_labeling_job_specialist_pool")
+              // Full resource name:
+              // projects/{project}/locations/{location}/specialistPools/{specialist_pool_id}


SpecialistPoolName.of("project", "location", "specialistPool");

chingor13 · 2020-12-15T21:50:45Z

samples/snippets/src/main/java/aiplatform/CreateTrainingPipelineCustomJobSample.java

+    PipelineServiceSettings settings =
+        PipelineServiceSettings.newBuilder()
+            .setEndpoint("us-central1-aiplatform.googleapis.com:443")
+            .build();


Consider adding a comment to this effect.

stale

samples: adds custom mode, action recognition samples and tests

a818952

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020

product-auto-label bot added the samples Issues that are directly related to samples. label Dec 11, 2020

lesv reviewed Dec 11, 2020

View reviewed changes

lesv approved these changes Dec 11, 2020

View reviewed changes

fix: per reviewer

43f24be

fix: linter

1fc163a

fix: per linter

46f224e

chore: adds env vars

e8830e8

fix: more linter

3c9e5d1

fix: remove env vars

de00a7c

fix: adds env vars correct way, fixes to deploy model sample

cd6657d

telpirion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2020

telpirion marked this pull request as ready for review December 14, 2020 00:51

telpirion requested a review from a team December 14, 2020 00:51

telpirion requested review from a team as code owners December 14, 2020 00:51

telpirion requested a review from chingor13 December 14, 2020 00:51

chingor13 previously requested changes Dec 14, 2020

View reviewed changes

telpirion added 2 commits December 14, 2020 12:29

Merge branch 'master' into additional-samples

f1fe3df

fix: loads env vars

1ea481e

telpirion added 2 commits December 14, 2020 19:14

fix: refactor to use Gson

891048c

Merge branch 'master' into additional-samples

d60a3c3

telpirion requested a review from chingor13 December 15, 2020 03:21

fix: lint

e562308

chingor13 reviewed Dec 15, 2020

View reviewed changes

telpirion added 2 commits December 16, 2020 11:22

fix: per reviewer

318d911

fix:lint

6a0d859

chingor13 approved these changes Dec 16, 2020

View reviewed changes

telpirion merged commit 081f87e into master Dec 16, 2020

telpirion deleted the additional-samples branch December 16, 2020 23:16

		// A working docker image can be found at
		// gs://cloud-samples-data/ai-platform/mnist_tfrecord/custom_job

samples: adds custom model, action recognition samples and tests #111

samples: adds custom model, action recognition samples and tests #111

Conversation

telpirion commented Dec 11, 2020

generated-files-bot bot commented Dec 11, 2020

snippet-bot bot commented Dec 11, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lesv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

telpirion Dec 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

generated-files-bot bot commented Dec 11, 2020

generated-files-bot bot commented Dec 11, 2020

codecov bot commented Dec 11, 2020 • edited Loading

Codecov Report

generated-files-bot bot commented Dec 11, 2020

generated-files-bot bot commented Dec 11, 2020

generated-files-bot bot commented Dec 11, 2020

generated-files-bot bot commented Dec 11, 2020

generated-files-bot bot commented Dec 12, 2020

telpirion commented Dec 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

generated-files-bot bot commented Dec 14, 2020

chingor13 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snippet-bot bot commented Dec 11, 2020 •

edited

Loading

telpirion Dec 16, 2020 •

edited

Loading

codecov bot commented Dec 11, 2020 •

edited

Loading