WIP. First pass at ndb.eventloop.EventLoop implementation. #6353

chrisrossi · 2018-10-31T19:07:37Z

Does not implement RPC integration.

ndb/src/google/cloud/ndb/eventloop.py

+        self.queue = []
+        self.rpcs = {}
+
+    def clear(self):


ndb/src/google/cloud/ndb/eventloop.py

+                _logging_debug('  queue = %s', queue)
+            if rpcs:
+                _logging_debug('  rpcs = %s', rpcs)
+            self.__init__(self.clock)


ndb/src/google/cloud/ndb/eventloop.py

+                _, callback, args, kwargs = self.queue.pop(0)
+                _logging_debug('event: %s', callback.__name__)
+                callback(*args, **kwargs)
+                # TODO: What if it raises an exception?


chrisrossi · 2018-10-31T19:20:59Z

I'm not sure I can make heads or tails of the CircleCI failure. Seems to have something to do with google.cloud.asset

tseaver · 2018-10-31T20:05:18Z

@chrisrossi The CI failure is breakage from googleapis-common-protos 1.5.4: see PR #6355.

Or maybe the generated asset docstring breakage addressed in PR #6351.

tseaver · 2018-10-31T20:29:24Z

@chrisrossi A rebase against the current master should get you back to green on CircleCI.

…nt RPC integration.

ndb/src/google/cloud/ndb/eventloop.py

+                _, callback, args, kwargs = self.queue.pop(0)
+                _logging_debug('event: %s', callback.__name__)
+                callback(*args, **kwargs)
+                # TODO: What if it raises an exception?


chrisrossi · 2018-10-31T20:55:23Z

@chrisrossi A rebase against the current master should get you back to green on CircleCI.

Yep, thanks!

dhermes · 2018-10-31T20:57:41Z

FYI @tseaver I'm in the middle of a review, but holding back until done (sorry I didn't announce).

dhermes

Thanks for sending this. Sorry for the boatload of comments. Would you mind either:

Splitting future PRs into smaller chunks (i.e. one commit per method)
Sending smaller PRs?

With this many things flying around it can be hard to track all review comments.

ndb/src/google/cloud/ndb/eventloop.py

+def _noop(*args, **kw):
+    """Do nothing."""
+
+# TODO: Use utils.logging_debug when implemented


ndb/src/google/cloud/ndb/eventloop.py



 class EventLoop:
-    __slots__ = ()
+    """Constructor.


ndb/src/google/cloud/ndb/eventloop.py


-    def __init__(self, *args, **kwargs):
+    Fields:


ndb/src/google/cloud/ndb/eventloop.py

ndb/tests/unit/test_eventloop.py

+        ev.queue.append('baz')
+        ev.rpcs['qux'] = 'quux'
+        ev.clear()
+        assert not len(ev.current)


ndb/tests/unit/test_eventloop.py

-    def test_constructor():
+    def _make_one(**attrs):
+        """Use DummyClock"""
+        ev = eventloop.EventLoop(DummyClock())


ndb/tests/unit/test_eventloop.py

+        assert ev.clock is myclock
+
+    def test_clear_current(self):
+        """ For branch coverage. """


ndb/tests/unit/test_eventloop.py

+class DummyClock:
+    """Fake out clock class without having to actually read system clock or
+    sleep during tests.
+    """


ndb/src/google/cloud/ndb/eventloop.py

+            rpcs.clear()
+            _logging_debug('Cleared')
+
+    def insort_event_right(self, event):


ndb/src/google/cloud/ndb/eventloop.py

+        """Schedule a function call at a specific time in the future.
+
+        Arguments:
+            delay (number): Time in seconds to delay running the callback.


…is#6353) Implements `ndb.eventloop.EventLoop` except for integration with RPC.

chrisrossi requested a review from crwilcox as a code owner October 31, 2018 19:07

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2018

chrisrossi commented Oct 31, 2018

View reviewed changes

ndb/src/google/cloud/ndb/eventloop.py Outdated Show resolved Hide resolved

chrisrossi commented Oct 31, 2018

View reviewed changes

ndb/src/google/cloud/ndb/eventloop.py

self.queue = []

self.rpcs = {}

def clear(self):

This comment was marked as spam.

Sign in to view

chrisrossi commented Oct 31, 2018

View reviewed changes

chrisrossi requested review from dhermes and tseaver October 31, 2018 19:18

chrisrossi changed the title ~~WIP. First pass at ndb.eventloop.EvenLoop implementation.~~ WIP. First pass at ndb.eventloop.EventLoop implementation. Oct 31, 2018

First pass at ndb.eventloop.EvenLoop implementation. Does not impleme…

c69a532

…nt RPC integration.

chrisrossi force-pushed the ndb-eventloop branch from d40ea9b to c69a532 Compare October 31, 2018 20:50

tseaver reviewed Oct 31, 2018

View reviewed changes

dhermes closed this Oct 31, 2018

dhermes reopened this Oct 31, 2018

dhermes reviewed Oct 31, 2018

View reviewed changes

Chris Rossi added 7 commits November 1, 2018 09:33

Remove TODO, add reference to Issue #6360.

0bcf385

Use to do dependency injection for time module.

9512caf

Conform to style guides.

5ced0a8

Replace TODO with issue in issue tracker and note in Metadata.db

70dbb85

Style conformance.

95a94f4

Ran "nox -s blacken".

90ad15a

PEP8

e981c0c

dhermes approved these changes Nov 2, 2018

View reviewed changes

Minor doc cleanup.

5c1a2eb

chrisrossi merged commit 36ffa92 into googleapis:master Nov 2, 2018

chrisrossi deleted the ndb-eventloop branch November 2, 2018 17:57

chrisrossi pushed a commit to chrisrossi/google-cloud-python that referenced this pull request Feb 22, 2019

WIP: First pass at ndb.eventloop.EventLoop implementation (googleap…

20f25b0

…is#6353) Implements `ndb.eventloop.EventLoop` except for integration with RPC.

WIP. First pass at ndb.eventloop.EventLoop implementation. #6353

WIP. First pass at ndb.eventloop.EventLoop implementation. #6353

Conversation

chrisrossi commented Oct 31, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

chrisrossi commented Oct 31, 2018

tseaver commented Oct 31, 2018 • edited Loading

tseaver commented Oct 31, 2018

This comment was marked as spam.

chrisrossi commented Oct 31, 2018

dhermes commented Oct 31, 2018

dhermes left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Oct 31, 2018 •

edited

Loading