Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset: fix docs build. #6351

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Asset: fix docs build. #6351

merged 1 commit into from
Oct 31, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 31, 2018

Broken in #6349.

@tseaver tseaver added type: docs Improvement to the documentation for an API. codegen api: cloudasset Issues related to the Cloud Asset Inventory API. labels Oct 31, 2018
@tseaver tseaver requested a review from crwilcox October 31, 2018 18:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 31, 2018

Turns out there is moar b0rkage, due to the release of googleapis-common-protos 1.5.4. See my comment.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 31, 2018

PR #6355, when merged, should solve the additional b0rkage. I will rebase this one once it lands.

@tseaver tseaver mentioned this pull request Oct 31, 2018
Merged
@tseaver tseaver mentioned this pull request Oct 31, 2018
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Oct 31, 2018

Merging without review to get the master docs build back to green.

@tseaver tseaver merged commit 1ac2b0d into googleapis:master Oct 31, 2018
@tseaver tseaver deleted the 6349-asset-fix_borked_docstrings branch October 31, 2018 20:28
parthea pushed a commit that referenced this pull request Oct 21, 2023
@tseaver
Asset: fix docs build. (#6351)
85df8b0 
Broken in #6349.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. cla: yes This human has signed the Contributor License Agreement. codegen type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tseaver @googlebot