Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanner: fix tests #2406

Merged
merged 1 commit into from
Jun 23, 2017
Merged

spanner: fix tests #2406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions packages/spanner/system-test/spanner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2716,7 +2716,7 @@ var spanner = new Spanner(env);
transaction.run('SELECT * FROM TxnTable', function(err, rows) {
assert.ifError(err);

assert.strictEqual(rows.length, 1);
assert.strictEqual(rows.length, 2);

This comment was marked as spam.

Sign in to view


var row = rows[0].toJSON();

Expand Down Expand Up @@ -2747,7 +2747,7 @@ var spanner = new Spanner(env);
it('should accept an exact staleness', function(done) {
var options = {
readOnly: true,
exactStaleness: 4
exactStaleness: Math.ceil((Date.now() - records[2].timestamp) / 1000)

This comment was marked as spam.

Sign in to view

};

database.runTransaction(options, function(err, transaction) {
Expand All @@ -2757,9 +2757,7 @@ var spanner = new Spanner(env);
assert.ifError(err);
assert.strictEqual(rows.length, 2);

rows = rows.map(function(row) {
return row.toJSON();
});
rows = rows.map(exec('toJSON'));

assert.strictEqual(rows[0].Key, 'k0');
assert.strictEqual(rows[0].StringValue, 'v0');
Expand Down Expand Up @@ -2835,19 +2833,21 @@ var spanner = new Spanner(env);
transaction.run(query, function(err, rows) {
assert.ifError(err);

var row = rows[0].toJSON();
var originalRows = extend(true, {}, rows);

// Make arbitrary update.
table.update({
Key: row.Key,
StringValue: 'v33'
Key: rows[0].toJSON().Key,
StringValue: 'overridden value'
}, function(err) {
assert.ifError(err);

transaction.run(query, function(err, rows_) {
assert.ifError(err);

var row = rows_.pop().toJSON();
assert.strictEqual(row.StringValue, 'v3');
rows_ = extend(true, {}, rows_);

assert.deepStrictEqual(rows_, originalRows);

This comment was marked as spam.

Sign in to view


transaction.end(done);
});
Expand All @@ -2859,7 +2859,7 @@ var spanner = new Spanner(env);
it('should read with staleness & concurrent updates', function(done) {
var options = {
readOnly: true,
exactStaleness: 6
exactStaleness: Math.ceil((Date.now() - records[1].timestamp) / 1000)
};

database.runTransaction(options, function(err, transaction) {
Expand All @@ -2869,13 +2869,13 @@ var spanner = new Spanner(env);

transaction.run(query, function(err, rows) {
assert.ifError(err);
assert.strictEqual(rows.length, 1);

table.update({
Key: 'k4',
StringValue: 'v444'
StringValue: 'overridden value'
}, function(err) {
assert.ifError(err);
assert.strictEqual(rows.length, 1);

transaction.run(query, function(err, rows) {
assert.ifError(err);
Expand Down