spanner: fix tests #2406
Merged
spanner: fix tests #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
commented
Jun 23, 2017
| @@ -2747,7 +2747,7 @@ var spanner = new Spanner(env); | |||
| it('should accept an exact staleness', function(done) { | |||
| var options = { | |||
| readOnly: true, | |||
| exactStaleness: 4 | |||
| exactStaleness: Math.ceil((Date.now() - records[2].timestamp) / 1000) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
commented
Jun 23, 2017
| assert.strictEqual(row.StringValue, 'v3'); | ||
| rows_ = extend(true, {}, rows_); | ||
|
|
||
| assert.deepStrictEqual(rows_, originalRows); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
commented
Jun 23, 2017
| @@ -2716,7 +2716,7 @@ var spanner = new Spanner(env); | |||
| transaction.run('SELECT * FROM TxnTable', function(err, rows) { | |||
| assert.ifError(err); | |||
|
|
|||
| assert.strictEqual(rows.length, 1); | |||
| assert.strictEqual(rows.length, 2); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling ee4a300 on stephenplusplus:spp--2397 into ** on GoogleCloudPlatform:master**. |
callmehiphop
approved these changes
Jun 23, 2017
This was referenced Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2397
Do not merge unless @callmehiphop approves
I re-wrote some tests that matched my expectations of what you intended, as well as what the options meant. Please make sure I didn't get any of this wrong.