fix: Fully qualifies all alternative types/members for obsolete ones. #6711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
Failures are because of the diffs that we accepted on #6657. |
jskeet
approved these changes
Jul 5, 2021
| @@ -28,7 +28,7 @@ namespace Google.Cloud.Diagnostics.AspNetCore | |||
| /// Implement this interface when traces are being generated by your environment | |||
| /// and sent to Google Cloud Tracing not via the Google.Cloud.Diagnostics library. | |||
| /// </summary> | |||
| [Obsolete("Inject an Common.ITraceContextInstead.")] | |||
| [Obsolete("Inject an Google.Cloud.Diagnostics.Common.ITraceContext instead.")] | |||
amanda-tarafa
force-pushed
the
diag-obsolete-alternatives
branch
from
fbc0b2f to
ee798cd
Compare
|
Nit fixed! You'll have to merge because of the diff. |
|
Righto - merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6672