CloudTraceExtensions.TryAddGoogleTraceContextProvider is missing

[EatonZ]

Hi,

I upgraded to Google.Cloud.Diagnostics.AspNetCore3 4.3.0-beta01 and have had to make a few changes to my code to accommodate various obsoletions and changes.

I have this code in my ConfigureServices method:
services.AddSingleton<ITraceContext>(new GoogleTraceProvider());

In the beta this no longer compiles. It tells me to: "Use CloudTraceExtensions.TryAddGoogleTraceContextProvider instead."

That method does not seem to exist.

[jskeet]

Thanks for the report - I'll have a look on Monday. It's possible that the message should just be changed to "Use CloudTraceExtensions.AddGoogleTrace instead" - that method definitely does exist.

[amanda-tarafa]

It's here

google-cloud-dotnet/apis/Google.Cloud.Diagnostics.AspNetCore/Google.Cloud.Diagnostics.AspNetCore/Trace/CloudTraceExtension.cs

Line 157 in ceb62cb

public static IServiceCollection TryAddGoogleTraceContextProvider(this IServiceCollection services)

[EatonZ]

@amanda-tarafa Is it not in this beta? There is only 1 CloudTraceExtensions class showing up and it looks like this:

[jskeet]

@EatonZ: That's a different class - the one Amanda pointed to before is in Google.Cloud.Diagnostics.AspNetCore

[EatonZ]

@jskeet I figured it out now.
The obsoletion suggested this: CloudTraceExtensions.TryAddGoogleTraceContextProvider
When it should be this: CloudTraceExtension.TryAddGoogleTraceContextProvider

There is a CloudTraceExtensions and a CloudTraceExtension class.
IntelliSense didn't pick up the non-s version immediately.

[amanda-tarafa]

Ah yes, sorry for the confusion. I'll update the Obsolete suggestion to include the full namespace and remove the s.

The class in Common is new so I named it with the usual naming convention, with the s. The one in AspNetCore* it's older and changing the name now to include the s would be breaking.