This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
bug: only install the required headers #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install rule was creating unexpected directories in the `$PREFIX/include` path, such as `google/cloud/spanner/integration_tests`. Fixed the install rules to only install the headers associated with specific targets.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
==========================================
- Coverage 94.22% 94.21% -0.01%
==========================================
Files 159 158 -1
Lines 10836 10837 +1
==========================================
Hits 10210 10210
- Misses 626 627 +1
Continue to review full report at Codecov.
|
scotthart
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @devbww, @devjgm, and @mr-salty)
devjgm
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…panner#993) The install rule was creating unexpected directories in the `$PREFIX/include` path, such as `google/cloud/spanner/integration_tests`. Fixed the install rules to only install the headers associated with specific targets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install rule was creating unexpected directories in the
$PREFIX/includepath, such asgoogle/cloud/spanner/integration_tests. Fixed the install rules toonly install the headers associated with specific targets.
Fixes #926
This change is