Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

The install rules create extra directories in $PREFIX/include #926

Closed
coryan opened this issue Oct 4, 2019 · 0 comments · Fixed by #993
Closed

The install rules create extra directories in $PREFIX/include #926

coryan opened this issue Oct 4, 2019 · 0 comments · Fixed by #993
Assignees
@coryan
Labels
api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. priority: p2 Lowest priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Spanner: Beta

Comments

@coryan
Copy link
Contributor

coryan commented Oct 4, 2019

The install rules seem to be creating extra directories in $PREFIX/include, such as doc, integration_tests, and samples.

Probably because we just install all the .h files in any subdirectory of google/cloud/spanner.

We should consider using the google_cloud_cpp_install_headers from google-cloud-cpp.
@coryan coryan added priority: p2 Lowest priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 4, 2019
@coryan coryan added this to the Spanner: Beta milestone Oct 4, 2019
@coryan coryan self-assigned this Oct 28, 2019
@coryan coryan mentioned this issue Oct 28, 2019
Merged
@google-cloud-label-sync google-cloud-label-sync bot added the api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. label Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@coryan coryan

Labels
api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. priority: p2 Lowest priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
Spanner: Beta
Development

Successfully merging a pull request may close this issue.

bug: only install the required headers
1 participant
@coryan