Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use explicit mocha imports #1175

Merged
merged 2 commits into from
Jan 2, 2020
Merged

refactor: use explicit mocha imports #1175

merged 2 commits into from
Jan 2, 2020

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 29, 2019
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 30, 2019
@bcoe bcoe mentioned this pull request Dec 30, 2019
Closed
@kjin
Copy link
Contributor

kjin commented Jan 2, 2020

Don't you need before, beforeEach, etc. as well?

Also, I don't think all files are being touched here. Was this run as part of a script?

@codecov
Copy link

codecov bot commented Jan 2, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@aaa2af8). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1175   +/-   ##
=========================================
  Coverage          ?   94.75%           
=========================================
  Files             ?       99           
  Lines             ?     6543           
  Branches          ?      514           
=========================================
  Hits              ?     6200           
  Misses            ?      181           
  Partials          ?      162
Impacted Files Coverage Δ
src/plugins/plugin-pg.ts 75.51% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa2af8...2d9ce2e. Read the comment docs.

@bcoe bcoe merged commit a6f825e into master Jan 2, 2020
@bcoe bcoe deleted the require-mocha branch January 2, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AVaksman AVaksman AVaksman approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JustinBeckwith @kjin @AVaksman @bcoe @googlebot @kokoro-team