Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests are failing on main branch #1177

Closed
bcoe opened this issue Dec 30, 2019 · 0 comments · Fixed by #1179
Closed

tests are failing on main branch #1177

bcoe opened this issue Dec 30, 2019 · 0 comments · Fixed by #1179
Assignees
@kjin
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bcoe
Copy link
Contributor

bcoe commented Dec 30, 2019

For the last few PRs that have come in, I'm noticing that most of the Circle CI tests are failing, see #1174, #1175.
@bcoe bcoe added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 30, 2019
@kjin kjin mentioned this issue Jan 2, 2020
Merged
@kjin kjin closed this as completed in #1179 Jan 2, 2020
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjin kjin

Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle pg 7.16.0+ undefined Result#fields kjin/cloud-trace-nodejs
2 participants
@bcoe @kjin