Make the Tags a set to avoid issues of DeDup #203
Conversation
…ing dedup calls Tested 👍
|
@tstromberg I saw that you merged a quick fix for tags, would you like me to close this? |
|
@MushuEE - Sorry about that. I merged a fix because I had made because I wanted to give more time to consider the implications of changing the data format. After looking more closely at the code, I like your PR better. Do you mind updating the merge conflict? I'll be able to merge it then. |
|
Merge done 👍 |
| @@ -160,7 +160,7 @@ | |||
| {{ end }} | |||
| </td> | |||
| <td class="cell-tags"> | |||
| {{ range .Tags }}<div class="gh-tag tag-{{ .ID }}" title="{{ .Desc }}">{{ .ID }}</div> {{ end }} | |||
| {{ range $k, $_ := .Tags }}<div class="gh-tag tag-{{ $k.ID }}" title="{{ $k.Desc }}">{{ $k.ID }}</div> {{ end }} | |||
There was a problem hiding this comment.
Ahh, now I remember why I did this: consistent sorting of tags during display. I see that the Go developers did add sorting to template iteration though, so maybe this isn't a problem after all:
If it is, we can always add a slice representation later. Thanks!
There was a problem hiding this comment.
was a concern but yep, should be able to do one sort to slice right before template generation👍
Translated all tags into a set which should remove the need to ever track dupes and or sort by ID
Fix for #196
*I think there are easier ways to solve this but I am learning Go and wanted to use this as an opportunity to get a little better. Not hard feelings if this gets closed! Happy to solve the bug using
dedupor another method. I think this is just more resilient long term.Tested 👍