Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Similar tag is repeated multiple times #196

Closed
RCheesley opened this issue Jul 30, 2020 · 1 comment · Fixed by #204
Closed

Similar tag is repeated multiple times #196

RCheesley opened this issue Jul 30, 2020 · 1 comment · Fixed by #204

Comments

@RCheesley
Copy link
Contributor

I noticed that the similar tag seems to be getting repeated for some of the PR's - not sure if it is a bug or by design!

screenshot-127 0 0 1_8080-2020 07 30-14_29_36

Currently on v1.2.1.
@MushuEE
Copy link
Contributor

MushuEE commented Aug 16, 2020

Looking at minikube dashboard seeing the same

image

Options for fixes:

  1. Make the Tags a set map[*Tag]bool so that there are never dupe Tags.
  2. Find the reason there are so many 'similar' tags
  3. check if that tag already exists and do not re-append to Tags.

@MushuEE MushuEE mentioned this issue Aug 16, 2020
Merged
@tstromberg tstromberg mentioned this issue Aug 19, 2020
Merged
@maelvls maelvls mentioned this issue Apr 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing call to dedup tags after refactor tstromberg/triage-party
2 participants
@RCheesley @MushuEE