Golangci linting cleanup

.gitignore

@@ -25,6 +25,9 @@ vendor/
 # vim
 *~
 
+#goland
+.idea
+
 # macOS
 .DS_Store
 

pkg/hubbub/item.go

@@ -193,8 +193,8 @@ func (h *Engine) conversation(i GitHubItem, cs []*Comment, age time.Time) *Conve
 
 	// Loose, but good enough
 	months := time.Since(co.Created).Hours() / 24 / 30
-	co.CommentersPerMonth = float64(co.CommentersTotal) / float64(months)
-	co.ReactionsPerMonth = float64(co.ReactionsTotal) / float64(months)
+	co.CommentersPerMonth = float64(co.CommentersTotal) / months
+	co.ReactionsPerMonth = float64(co.ReactionsTotal) / months
 	return co
 }
 

pkg/hubbub/pull_requests.go

@@ -313,7 +313,7 @@ func reviewState(pr GitHubItem, timeline []*github.Timeline, reviews []*github.P
 		return Closed
 	}
 
-	klog.V(1).Infof("PR #%d has %d reviews, hoping one is for %s ...", pr.GetNumber(), (reviews), lastCommitID)
+	klog.V(1).Infof("PR #%d has %d reviews, hoping one is for %s ...", pr.GetNumber(), len(reviews), lastCommitID)
 	lastReview := time.Time{}
 	for _, r := range reviews {
 		if r.GetCommitID() == lastCommitID || lastCommitID == "" {

pkg/hubbub/similar.go

@@ -50,7 +50,7 @@ var removeWords = map[string]bool{
 
 // normalize titles for a higher hit-rate
 func normalizeTitle(t string) string {
-	keep := []string{}
+	var keep []string
 	for _, word := range strings.Split(t, " ") {
 		word = nonLetter.ReplaceAllString(word, "")
 		if len(word) == 0 {
@@ -97,7 +97,10 @@ func (h *Engine) updateSimilarityTables(rawTitle, url string) {
 	similarTo := []string{}
 
 	h.titleToURLs.Range(func(k, v interface{}) bool {
-		otherTitle := k.(string)
+		otherTitle, ok := k.(string)
+		if !ok {
+			klog.V(1).Infof("key %q is not of type string", k)
+		}
 		if otherTitle == title {
 			return true
 		}

pkg/persist/gocache.go

@@ -50,7 +50,10 @@ func newerThanMem(c *cache.Cache, key string, t time.Time) *Thing {
 		return nil
 	}
 
-	th := x.(*Thing)
+	th, ok := x.(*Thing)
+	if !ok {
+		klog.V(1).Infof("%s is not of type Thing", key)
+	}
 
 	if th.Created.Before(t) {
 		klog.V(2).Infof("%s in cache, but %s is older than %s", key, logu.STime(th.Created), logu.STime(t))

pkg/persist/mem.go

@@ -13,7 +13,6 @@
 // limitations under the License.
 
 // Package persist provides a bootstrap for the in-memory cache
-
 package persist
 
 import (

pkg/triage/github.go

@@ -45,7 +45,7 @@ func MustReadToken(path string, env string) string {
 		klog.Infof("loaded %d byte github token from %s", len(token), env)
 	}
 
-	token = strings.TrimSpace(string(token))
+	token = strings.TrimSpace(token)
 	if len(token) < 8 {
 		klog.Exitf("github token impossibly small: %q", token)
 	}

pkg/triage/triage.go

@@ -175,7 +175,7 @@ func closedAge(fs []hubbub.Filter) time.Duration {
 
 	if oldest == 0 {
 		klog.Warningf("I need closed data, but I'm not sure how old: picking 4 days")
-		return time.Duration(24 * 4 * time.Hour)
+		return 24 * 4 * time.Hour
 	}
 
 	return oldest

pkg/updater/updater.go

@@ -17,6 +17,7 @@ package updater
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"math/rand"
 	"sync"
@@ -205,32 +206,30 @@ func (u *Updater) update(ctx context.Context, s triage.Collection, newerThan tim
 
 // Run a single collection, optionally forcing an update
 func (u *Updater) RefreshCollection(ctx context.Context, id string, newerThan time.Time, force bool) (bool, error) {
-	updated := false
 	klog.V(3).Infof("RefreshCollection: %s newer than %s, force=%v (locking mutex)", id, newerThan, force)
 	u.mutex.Lock()
 	defer u.mutex.Unlock()
 
 	s, err := u.party.LookupCollection(id)
 	if err != nil {
-		return updated, err
+		return false, err
 	}
 
 	if err := u.shouldUpdate(s.ID, force); err != nil {
 		klog.Infof("reason for updating %q: %v", s.ID, err)
 
 		err := u.update(ctx, s, newerThan)
 		if err != nil {
-			return updated, err
+			return false, err
 		}
-		updated = true
 	}
-	return updated, nil
+	return true, nil
 }
 
 // Persist saves results to the persistence layer
 func (u *Updater) Persist() error {
 	if !u.persistStart.IsZero() {
-		return fmt.Errorf("already persisting!")
+		return errors.New("already persisting")
 	}
 
 	// advisory lock
@@ -291,7 +290,7 @@ func (u *Updater) RunOnce(ctx context.Context, force bool) (bool, error) {
 	}()
 
 	if force {
-		klog.Warningf(">>> RunOnce has force enabled")
+		klog.Warning(">>> RunOnce has force enabled")
 	} else {
 		klog.V(3).Infof("RunOnce: force=%v", force)
 	}
@@ -308,7 +307,7 @@ func (u *Updater) RunOnce(ctx context.Context, force bool) (bool, error) {
 
 	newerThan := start.Add(-2 * minFlushAge)
 	if u.updateCycles == 0 {
-		klog.Infof("have not yet completed a cycle - will accept stale results")
+		klog.Info("have not yet completed a cycle - will accept stale results")
 		newerThan = time.Time{}
 	}