Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of cleanups. Resisted several which were too opinionated and thought might be contentious. This resulted in a bug fix around
len(review)
Fixes:
f
formatting func for non formatting stringsThings to think about:
JSEscapeString
or place a // no lint comment that it has been evaluated to be oktime.Time
return fromcachedIssueComments
andcachedReviews
is never usedhubbub/item.go:33
andhubbub/match.go:15
. These should be refactor IHMOSigned-off-by: Ken Sipe [email protected]