Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using stop_areas.txt instead of location_groups.txt #338

Closed
omar-kabbani opened this issue Jul 4, 2022 · 8 comments
Closed

Using stop_areas.txt instead of location_groups.txt #338

omar-kabbani opened this issue Jul 4, 2022 · 8 comments
Labels
Extension: GTFS-Flex Issues and Pull Requests that focus on GTFS-Flex Extension GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule

Comments

@omar-kabbani
Copy link
Contributor

omar-kabbani commented Jul 4, 2022

This issue relates to the GTFS-Flex proposal, and is opened following a series of roundtable discussion to resolve the outstanding issues with the proposal. These discussions were hosted by MobilityData and attended by various stakeholders within the GTFS community.

You can find the GTFS-Flex proposal here: https://github.com/MobilityData/gtfs-flex/blob/master/spec/reference.md


The files areas.txt and stop_areas.txt in the current spec serve the same purpose as location_groups.txt. To avoid duplication, stops and GeoJSON locations can be grouped using stop_areas.txt. A name can be assigned to the group using the file areas.txt.

Here’s an example:
Instead of this:

location_groups.txt

location_group_id location_id location_group_name
group1 stop1 Downtown
group1 stop2 Downtown
group1 zoneA Downtown
group2 stop3 Suburbs
group2 stop4 Suburbs

We use this:

stop_areas.txt

area_id stop_id
group1 stop1
group1 stop2
group1 zoneA
group2 stop3
group2 stop4

areas.txt

area_id area_name
group1 Downtown
group2 Suburbs
@leonardehrenfried
Copy link
Contributor

leonardehrenfried commented Jul 7, 2022

Having worked with both Flex V2 and Fares V2 I really like this idea.

@westontrillium
Copy link
Contributor

This makes sense to reduce redundancy. Do we need to include areas.txt in the change? I do not think a "location group" needs a name.

@westontrillium
Copy link
Contributor

westontrillium commented Jul 7, 2022

Quick note that if we keep the location id primary key in locations.geojson (see my thoughts on the proposal to change this here), we will need to amend stop_areas.txt to allow reference to locations.geojson.id.

@tsherlockcraig
Copy link

+1

@e-lo
Copy link

e-lo commented Jul 12, 2022

LGTM

@NomeQ
Copy link

NomeQ commented Aug 30, 2022

@westontrillium as much as I like simplicity and it feels nice to make the change as lightweight as possible, I think there are good cases for keeping location_group_name (or, area_name).

Some agencies might find it very useful, especially those building tools on top of the GTFS. Some possible examples I can think of include using the GTFS in website tools, and wanting to create consistent rider-facing information, e.g. if there is a fare table for different fares/different zones, and wanting to show those zones on a map with labels consistent with other materials.

Otherwise, I think moving fields into areas.txt and stop_areas.txt makes a lot of sense. The only part I'm wary of (which is a producer issue, and not really a good factor for guiding design) is that as it is, using location_groups.txt as a separate file helps enable sort of Frankenstein feeds where flex v2 and fares v2 data are cobbled onto an existing feed ad-hoc. Again, this isn't a reason to avoid good design—just a note for producers to think about in terms of production pipelines as they currently exist.

@omar-kabbani
Copy link
Contributor Author

I agree with @NomeQ on keeping a rider-facing name if agencies want to use the field. areas.txt is where data producers can optionally provide an area name.
+1 I do not think having fare areas and flex areas in the same file should be an issue.

westontrillium added a commit to westontrillium/gtfs-flex that referenced this issue Oct 27, 2022
@emmambd emmambd added GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Extension: GTFS-Flex Issues and Pull Requests that focus on GTFS-Flex Extension labels May 10, 2023
@tzujenchanmbd
Copy link
Collaborator

Closing this issue because of the consensus in the previous comments, and the subsequent commit to the proposal has been done by @westontrillium at this PR.

We can reopen this issue if there is any concern during adoption process later.

(MobilityData has opened issue#382 to cover the service discovery of GTFS-Flex)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extension: GTFS-Flex Issues and Pull Requests that focus on GTFS-Flex Extension GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule
Projects
None yet
Development

No branches or pull requests

8 participants