-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using stop_areas.txt instead of location_groups.txt #338
Comments
Having worked with both Flex V2 and Fares V2 I really like this idea. |
This makes sense to reduce redundancy. Do we need to include areas.txt in the change? I do not think a "location group" needs a name. |
Quick note that if we keep the location id primary key in |
+1 |
LGTM |
@westontrillium as much as I like simplicity and it feels nice to make the change as lightweight as possible, I think there are good cases for keeping location_group_name (or, area_name). Some agencies might find it very useful, especially those building tools on top of the GTFS. Some possible examples I can think of include using the GTFS in website tools, and wanting to create consistent rider-facing information, e.g. if there is a fare table for different fares/different zones, and wanting to show those zones on a map with labels consistent with other materials. Otherwise, I think moving fields into areas.txt and stop_areas.txt makes a lot of sense. The only part I'm wary of (which is a producer issue, and not really a good factor for guiding design) is that as it is, using location_groups.txt as a separate file helps enable sort of Frankenstein feeds where flex v2 and fares v2 data are cobbled onto an existing feed ad-hoc. Again, this isn't a reason to avoid good design—just a note for producers to think about in terms of production pipelines as they currently exist. |
I agree with @NomeQ on keeping a rider-facing name if agencies want to use the field. |
Closing this issue because of the consensus in the previous comments, and the subsequent commit to the proposal has been done by @westontrillium at this PR. We can reopen this issue if there is any concern during adoption process later. (MobilityData has opened issue#382 to cover the service discovery of GTFS-Flex) |
This issue relates to the GTFS-Flex proposal, and is opened following a series of roundtable discussion to resolve the outstanding issues with the proposal. These discussions were hosted by MobilityData and attended by various stakeholders within the GTFS community.
You can find the GTFS-Flex proposal here: https://github.com/MobilityData/gtfs-flex/blob/master/spec/reference.md
The files
areas.txt
andstop_areas.txt
in the current spec serve the same purpose aslocation_groups.txt
. To avoid duplication, stops and GeoJSON locations can be grouped usingstop_areas.txt
. A name can be assigned to the group using the fileareas.txt
.Here’s an example:
Instead of this:
location_groups.txt
We use this:
stop_areas.txt
areas.txt
The text was updated successfully, but these errors were encountered: