Replace location groups with stop areas #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-cline
approved these changes
May 5, 2023
philip-cline
requested changes
May 5, 2023
Co-authored-by: Philip Cline <[email protected]>
…reflect changes suggested in PR
philip-cline
approved these changes
May 9, 2023
miles-grant-ibigroup
approved these changes
May 11, 2023
| return locationGroupById.get(haltId).location_group_name; | ||
| } else if (stopAreaById.containsKey(haltId)) { | ||
| Area area = areaById.get(haltId); | ||
| return area.area_name != null ? area.area_name : area.area_id; |
There was a problem hiding this comment.
Why do we return the id as a fallback?
There was a problem hiding this comment.
@philip-cline Does the UI require the area_id? If not, can the default fromTerminusNameUnknown or toTerminusNameUnknown value be used?
There was a problem hiding this comment.
The UI doesn't require the area_id but I think it looks a lot better while we work on implementing area names.
… is not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Deprecated location groups and replace with stop areas and areas.