Enables MSAN for Suricata #4455
Conversation
projects/suricata/build.sh
Outdated
| @@ -45,6 +45,7 @@ make install | |||
| cd .. | |||
|
|
|||
| export CARGO_BUILD_TARGET="x86_64-unknown-linux-gnu" | |||
| rustup component add rust-src --toolchain nightly | |||
There was a problem hiding this comment.
You may want to do this in the Docker image, so that it works for other Rust projects
There was a problem hiding this comment.
Can you submit a patch to https://github.com/google/oss-fuzz/blob/master/infra/base-images/base-builder/Dockerfile#L79 with a comment on why it is needed. Thanks!
There was a problem hiding this comment.
It comes from this discussion :
#3469 (comment)
We need to have -Z build-std to rebuild Rust standard library with MSAN
And to have this to work, we need a few things including this rustup component add rust-src cf
https://doc.rust-lang.org/cargo/reference/unstable.html#build-std
projects/suricata/build.sh
Outdated
| @@ -45,6 +45,7 @@ make install | |||
| cd .. | |||
|
|
|||
| export CARGO_BUILD_TARGET="x86_64-unknown-linux-gnu" | |||
| rustup component add rust-src --toolchain nightly | |||
There was a problem hiding this comment.
Can you submit a patch to https://github.com/google/oss-fuzz/blob/master/infra/base-images/base-builder/Dockerfile#L79 with a comment on why it is needed. Thanks!
|
MSAN build is failing because we need Suricata upstream merge of OISF/suricata#5422 |
|
Ping us here once this is ready to merge. |
|
Ping @inferno-chromium |
Tip: You can force this yourself by pushing to this PR. |
catenacyber
force-pushed
the
suricatamsan
branch
from
60e0653 to
a1f71fe
Compare
|
Thanks Johnathan, I rebased and force-pushed |
|
Does the CI take into account the changes to base-builder ? |
I think so? |
|
If the CI succeeds with this new commit, I guess CI was wrong last time |
I dont think so. But this should work, let me remove your dummy thing and commit. keep an eye on build tmrw. |
Maybe I misunderstood what you meant. Did you make changes in this PR? |
|
Looks like it is working :-) |
Will work when OISF/suricata#5422 gets merged