Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuzz: better configure checks for MSAN building #5422

Closed
wants to merge 1 commit into from
Closed

fuzz: better configure checks for MSAN building #5422

wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
None

Describe changes:

  • Improves configure check for Rust nightly version, in order to build with MSAN if needed

It seems #5411 was not good enough for oss-fuzz Docker

Replaces #5421 with version working bot locally and on oss-fuzz with catenacyber/oss-fuzz@4c922f1

Let's check if CI is happy with other systems

@catenacyber
fuzz: better configure checks for MSAN building
5a82226 
More compatible check for rust nightly
Checks for CARGO_BUILD_TARGET
Builds release or debug mode independently
@catenacyber catenacyber mentioned this pull request Sep 17, 2020
Merged
@jasonish
Copy link
Member

Would it be useful to duplicate the ubuntu-18-04-fuzz CI test, use Rust nightly then do a post-configure check that this was setup correctly?

@catenacyber
Copy link
Contributor Author

Would it be useful to duplicate the ubuntu-18-04-fuzz CI test, use Rust nightly then do a post-configure check that this was setup correctly?

For at least one with fuzzing, I think it would be useful to have Rust nightly, as it is needed to get the best out of fuzzing Rust.
Between the Debian one, or the Ubuntu one, I do not know if it makes a difference

@jasonish
Copy link
Member

Would it be useful to duplicate the ubuntu-18-04-fuzz CI test, use Rust nightly then do a post-configure check that this was setup correctly?

For at least one with fuzzing, I think it would be useful to have Rust nightly, as it is needed to get the best out of fuzzing Rust.
Between the Debian one, or the Ubuntu one, I do not know if it makes a difference

I'd probably go with a new Ubuntu 20.04 test.

@jasonish jasonish mentioned this pull request Sep 22, 2020
Closed
@catenacyber
Copy link
Contributor Author

Ok, so... do you want this new ubuntu test qs part of this PR ?

@jasonish
Copy link
Member

Ok, so... do you want this new ubuntu test qs part of this PR ?

Doesn't really matter. But should probably be based on this PR.

@catenacyber
Copy link
Contributor Author

@jasonish do you manage to install/run dustup in Github CI builds ?
Or do you know an equivalent of rustup component add rust-src without using rustup ?

@jasonish
Copy link
Member

@jasonish do you manage to install/run dustup in Github CI builds ?
Or do you know an equivalent of rustup component add rust-src without using rustup ?

Rustup is used in GitHub CI builds, see: https://github.com/OISF/suricata/blob/master/.github/workflows/builds.yml#L916 for an example.

@catenacyber
Copy link
Contributor Author

Rustup is used in GitHub CI builds

I see its download, but then I cannot use it as it is not in the PATH cf
https://github.com/catenacyber/suricata/runs/1165320022?check_suite_focus=true

@victorjulien victorjulien mentioned this pull request Sep 29, 2020
Merged
@victorjulien
Copy link
Member

Merged in #5452, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catenacyber @jasonish @victorjulien