Improve Dropdown Behavior in Questionnaire Items #2393

qaziabubakar-vd · 2023-12-29T14:36:01Z

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes # #2228

Description
Improved the dropdown behaviour, disabled the search within the field once an option is selected.
Once the text is cleared, showed the list of options again in the dropdown

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

I have read and acknowledged the Code of conduct.
I have read the Contributing page.
I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

…' into issue-2228-dropdown-non-editable

...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt

ellykits · 2024-02-13T07:31:55Z

@qaziabubakar-vd Any updates on this PR? Update the PR with the functionality to reset/clear the selected item.

qaziabubakar-vd · 2024-02-13T08:01:57Z

@qaziabubakar-vd Any updates on this PR? Update the PR with the functionality to reset/clear the selected item.

I was assigned to another project but I will pick this back soon and add the implementation for resetting/clearing the selected item. Will post an update here and on the ticket.

...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt

…views/factories/DropDownViewHolderFactory.kt Co-authored-by: santosh-pingle <[email protected]>

…' into issue-2228-dropdown-non-editable # Conflicts: # datacapture/src/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt

… is selected or once user types in some text

… clearIcon

…opdown-non-editable # Conflicts: # datacapture/src/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt

...java/com/google/android/fhir/datacapture/test/views/DropDownViewHolderFactoryEspressoTest.kt

...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt

jingtang10 · 2024-03-26T17:52:42Z

...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt

              }
            }
          }

+        autoCompleteTextView.doAfterTextChanged {


i don't know if you can use draft answer here... try to set draft answer and reset the widget? i guess one problem might be the cursor moving? @aditya-07 do you have experience with this?

jingtang10 · 2024-06-22T08:53:04Z

Hey @qaziabubakar-vd any progress here? Thanks!

…28-dropdown-non-editable

- Simpler logic - Use `questionnaireViewItem.answers` state to check if the AutoComplete is editable or not - Remove keyListener to make the AutoComplete not editable - Hide keyboard after typing an option then clicking the shown option - Add cool ripple effect on clicking the clear input icon

FikriMilano · 2025-01-28T08:12:07Z

...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt

+        clearInputIcon.setOnClickListener {
+          context.lifecycleScope.launch {
+            delay(200) // to show ripple effect on the icon before clearing the answer
+            questionnaireViewItem.clearAnswer()
+          }
+        }


On second thoughts, I can probably move this to the init() function, it's currently in bind()

FikriMilano · 2025-01-28T08:14:18Z

Remaining todo is test

FikriMilano · 2025-01-28T09:02:37Z

I couldn't add this new demo to the PR description (after refactor), since it's not my PR, but here you go.

dropdown-behavior-demo-2.webm

MJ1998 · 2025-01-28T14:05:29Z

...java/com/google/android/fhir/datacapture/test/views/DropDownViewHolderFactoryEspressoTest.kt

+    }
+
+    // Delay the execution to allow the view hierarchy to be fully initialized
+    Thread.sleep(1000)


Can you check if this is needed. Espresso should handle this automatically.

we don't actually, not sure why it's there

MJ1998 · 2025-01-28T14:06:25Z

...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt

+        }
+        clearInputIcon.setOnClickListener {
+          context.lifecycleScope.launch {
+            delay(200) // to show ripple effect on the icon before clearing the answer


This is unnecessary. May cause flakiness in test cases.

…28-dropdown-non-editable

FikriMilano · 2025-01-29T10:23:03Z

@jingtang10 @MJ1998 this is ready for review

* Upgrade SDC Version Fixes bug with PR google/android-fhir#2645 * rename Kader Job Aids flavor * Fix typo in add-application-flavors.mdx * Update SDC with google/android-fhir#2393 Fix

- Make the dropdown non-editable after an option is selected.

24404bb

f-odhiambo mentioned this pull request Dec 31, 2023

Make the selection drop-downs not editable #2228

Open

qaziabubakar-vd and others added 4 commits January 3, 2024 15:54

Show the dropdown once the text is deleted

730cd1b

Merge branch 'master' into issue-2228-dropdown-non-editable

5094e49

Spotless Apply

caeae47

Merge remote-tracking branch 'origin/issue-2228-dropdown-non-editable…

9e30f45

…' into issue-2228-dropdown-non-editable

qaziabubakar-vd marked this pull request as ready for review January 8, 2024 05:58

qaziabubakar-vd requested review from santosh-pingle and a team as code owners January 8, 2024 05:58

qaziabubakar-vd requested a review from yigit January 8, 2024 05:58

jingtang10 assigned santosh-pingle Jan 10, 2024

Merge branch 'master' into issue-2228-dropdown-non-editable

3bead63

jingtang10 mentioned this pull request Jan 15, 2024

Made the selection drop-downs not editable #2256

Closed

7 tasks

jingtang10 linked an issue Jan 15, 2024 that may be closed by this pull request

Make the selection drop-downs not editable #2228

Open

santosh-pingle reviewed Jan 16, 2024

View reviewed changes

santosh-pingle assigned qaziabubakar-vd and unassigned santosh-pingle Jan 16, 2024

Merge branch 'master' into issue-2228-dropdown-non-editable

a6959c6

jingtang10 added the kokoro:force-run label Feb 6, 2024

android-fhir-bot removed the kokoro:force-run label Feb 6, 2024

aditya-07 reviewed Feb 13, 2024

View reviewed changes

...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt Outdated Show resolved Hide resolved

qaziabubakar-vd and others added 7 commits February 26, 2024 14:38

Update datacapture/src/main/java/com/google/android/fhir/datacapture/…

dd3ead3

…views/factories/DropDownViewHolderFactory.kt Co-authored-by: santosh-pingle <[email protected]>

Update header_view.xml according to the new design

d5d7355

Merge remote-tracking branch 'origin/issue-2228-dropdown-non-editable…

916829e

…' into issue-2228-dropdown-non-editable # Conflicts: # datacapture/src/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt

Merge branch 'master' into issue-2228-dropdown-non-editable

6fbdf2e

Update DropDownViewHolderFactory

d6bf618

Merge branch 'master' into issue-2228-dropdown-non-editable

ebdfb28

Update DropDownViewHolderFactory to have a clear icon once the option…

d6a4545

… is selected or once user types in some text

qaziabubakar-vd and others added 6 commits March 15, 2024 16:43

clear answer from the questionnaireViewItem when the user taps on the…

32cb079

… clearIcon

Add new tests

c9baa38

Add new code comments

36d16fc

Merge remote-tracking branch 'Android-FHIR/master' into issue-2228-dr…

a35e0a7

…opdown-non-editable # Conflicts: # datacapture/src/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt

Resolve conflicts

36a1806

Merge branch 'master' into issue-2228-dropdown-non-editable

b305bb0

jingtang10 requested changes Mar 26, 2024

View reviewed changes

Merge branch 'master' into issue-2228-dropdown-non-editable

7e68464

dubdabasoduba requested a review from a team as a code owner October 23, 2024 21:01

dubdabasoduba requested a review from aditya-07 October 23, 2024 21:01

FikriMilano added 2 commits January 28, 2025 15:05

Merge branch 'master' of github.com:google/android-fhir into issue-22…

dd187c3

…28-dropdown-non-editable

FikriMilano force-pushed the issue-2228-dropdown-non-editable branch from 079ad81 to a994dc3 Compare January 28, 2025 08:06

FikriMilano reviewed Jan 28, 2025

View reviewed changes

Move clearInputIcon click listener to init function

fcf841e

Show dropdown once answer is cleared

12fb10b

FikriMilano force-pushed the issue-2228-dropdown-non-editable branch from 814b8ac to 12fb10b Compare January 28, 2025 08:56

MJ1998 reviewed Jan 28, 2025

View reviewed changes

FikriMilano added 4 commits January 29, 2025 09:03

Remove ripple effect on clear icon

d840f61

Add tests

041d121

spotless

c811179

Merge branch 'master' of github.com:google/android-fhir into issue-22…

3d1149b

…28-dropdown-non-editable

Rename test components

00d235c

ndegwamartin added a commit to opensrp/fhircore that referenced this pull request Jan 30, 2025

Update SDC with google/android-fhir#2393 Fix

34d7f85

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Dropdown Behavior in Questionnaire Items #2393

Improve Dropdown Behavior in Questionnaire Items #2393

qaziabubakar-vd commented Dec 29, 2023 •

edited

Loading

ellykits commented Feb 13, 2024

qaziabubakar-vd commented Feb 13, 2024

jingtang10 Mar 26, 2024

jingtang10 commented Jun 22, 2024

FikriMilano Jan 28, 2025 •

edited

Loading

FikriMilano commented Jan 28, 2025

FikriMilano commented Jan 28, 2025 •

edited

Loading

MJ1998 Jan 28, 2025

FikriMilano Jan 29, 2025

MJ1998 Jan 28, 2025

FikriMilano Jan 29, 2025

FikriMilano commented Jan 29, 2025

Improve Dropdown Behavior in Questionnaire Items #2393

Are you sure you want to change the base?

Improve Dropdown Behavior in Questionnaire Items #2393

Conversation

qaziabubakar-vd commented Dec 29, 2023 • edited Loading

ellykits commented Feb 13, 2024

qaziabubakar-vd commented Feb 13, 2024

jingtang10 Mar 26, 2024

Choose a reason for hiding this comment

jingtang10 commented Jun 22, 2024

FikriMilano Jan 28, 2025 • edited Loading

Choose a reason for hiding this comment

FikriMilano commented Jan 28, 2025

FikriMilano commented Jan 28, 2025 • edited Loading

MJ1998 Jan 28, 2025

Choose a reason for hiding this comment

FikriMilano Jan 29, 2025

Choose a reason for hiding this comment

MJ1998 Jan 28, 2025

Choose a reason for hiding this comment

FikriMilano Jan 29, 2025

Choose a reason for hiding this comment

FikriMilano commented Jan 29, 2025

qaziabubakar-vd commented Dec 29, 2023 •

edited

Loading

FikriMilano Jan 28, 2025 •

edited

Loading

FikriMilano commented Jan 28, 2025 •

edited

Loading