Made the selection drop-downs not editable

[kanahia1]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2228

Description
Made the selection drop-downs not editable

Alternative(s) considered
N/A

Type
Bug fix

Screenshots (if applicable)

Checklist

• I have read and acknowledged the Code of conduct.
• I have read the Contributing page.
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
• I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[omarismail94]

Can you add an instrumentation test here:
https://github.com/google/android-fhir/blob/master/datacapture/src/androidTest/java/com/google/android/fhir/datacapture/test/views/DropDownViewHolderFactoryEspressoTest.kt

to test that if a user tries to edit the text, it does not work?

[kanahia1]

Hi @omarismail94, I have added a test case that checks if the user is able to type or not. Since when the user tries to type text, it will throw an exception as it is not editable.
Can you please review it.
[247696f (#2256)]

[omarismail94]

Thanks @kanahia1 ! The CLA check is failing, can you resolve that here: https://cla.developers.google.com/clas

[kanahia1]

Hi @omarismail94 , I have submitted my CLA.
Can you please check it now.

[omarismail94]

thanks @kanahia1, GitHib Actions is failing due to Spotless failue: https://github.com/google/android-fhir/actions/runs/6531828200/job/17733797033?pr=2256

can you run spotless apply and upload the commit?

[jingtang10]

Thanks for fixing this @kanahia1. Usually with this type of change, we would like to see before/after screenshots or before/after videos. This makes the review process much easier.

[kanahia1]

Oh sorry @jingtang10 , I will try to upload screen recording/ screenshots from now on!

Here's a video demonstrating the non-edit behavior of drop-downs.

WhatsApp.Video.2023-10-17.at.18.49.39_0d2064f4.mp4

[kanahia1]

Hi @omarismail94 , I have made all the requested changes can you please review it

[jingtang10]

thanks very much!

[omarismail94]

@kanahia1 the change you have is causing two instrumentation test to fail:

• com.google.android.fhir.datacapture.test.views.DropDownViewHolderFactoryEspressoTest.shouldReturnFilteredDropDownMenuItems
• com.google.android.fhir.datacapture.test.views.DropDownViewHolderFactoryEspressoTest.shouldReturnFilteredWithNoResultsDropDownMenuItems

both fail due to:

Error performing 'type text(Coding)' on view 'view.getId()

I can replicate the test failure on my local machine. Can you do so on yours, and fix the broken tests?

[jingtang10]

closing this in favour of #2393