-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.Reduce space between question title & options & Make spacing a configurable attribute #1986
1.Reduce space between question title & options & Make spacing a configurable attribute #1986
Conversation
2.Make spacing a configurable attribute
Before SS (16dp padding between each question title and options) After default padding to 4dp SS |
Thank you, @khyativyasargus Such a good improvement. To my eyes, the 4dp still looks like it is more than 4dp. The 'Gender' padding seems smaller than the other ones? Is there padding on other elements which is making it appear to be more than 4dp? Thanks for working on this issue. |
Hi @shelaghm Thanks for inputs! > To my eyes, the 4dp still looks like it is more than 4dp. The 'Gender' padding seems smaller than the other ones? Is there padding on other elements which is making it appear to be more than 4dp? I think the screenshots I attached here is in bigger size visually that's why you might be feeling like it's more than 4dp. Let me share proper ss again and let me know on that. |
@khyativyasargus If you see default layout in the catalog app, it has instructions just below the question text. |
@khyativyasargus any update on this PR |
|
@santosh-pingle As Shelaghm observed, Questions with EditTextView as answer view having more space than others due to EditText default style outer space, you can notice in screenshots I shared. |
…tween-question-and-answer
Head branch was pushed to by a user without write access
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1967
Description
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.