Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDC] Reduce space between question title & options in default layout #1967

Closed
shelaghm opened this issue Apr 12, 2023 · 4 comments · Fixed by #1986
Closed

[SDC] Reduce space between question title & options in default layout #1967

shelaghm opened this issue Apr 12, 2023 · 4 comments · Fixed by #1986
Assignees
Labels
P2 Medium priority issue ux

Comments

@shelaghm
Copy link

Problem
The spacing between the question title and options is too big. It is also not configurable for developers so they can easily adjust.

Solution

  1. Adjust the default spacing to be 4dp (so it is consistent with a 4dp grid)
  2. Make spacing a configurable attribute

EmCare commit
1b9023b

cc @santosh-pingle @kunjan8794 @khyativyasargus @jingtang10

@shelaghm shelaghm added the ux label Apr 12, 2023
@shelaghm shelaghm changed the title [SDC] Reduced space between question title & options in default layout [SDC] Reduce space between question title & options in default layout Apr 12, 2023
@santosh-pingle
Copy link
Collaborator

@kunjan8794 @khyativyasargus
I see corresponding commit opened for this feature on your repository.
Are you going to create PR corresponding to main repository android fhir sdk?
Or you want me to look into it?

cc @jingtang10

@santosh-pingle santosh-pingle added the P2 Medium priority issue label Apr 17, 2023
@khyativyasargus
Copy link
Contributor

@santosh-pingle Sure. We will create PR for this in main repository.

@santosh-pingle
Copy link
Collaborator

@khyativyasargus thanks!, is there any approximate date by which we can expect the pull request?

@khyativyasargus
Copy link
Contributor

@santosh-pingle Yes, You can expect all PRs done by 24th April, Monday. Let me know if it's needed before that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority issue ux
Projects
None yet
3 participants